[Integrations] Add logic to install extra_packages agent checks #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miketheman it appears that travis is failing on I'm not sure why, as both |
|
also I'm not sure to see the difference with this other template |
tmichelet
force-pushed
the
tristan/integrations-recipe
branch
from
8b1d486 to
340c7d0
Compare
|
@miketheman travis fixed, thanks for your help! this is ready for review |
| @@ -0,0 +1,43 @@ | |||
| # | |||
| # Cookbook Name:: datadog | |||
| # Recipe:: dd-agent | |||
There was a problem hiding this comment.
nitpick: should be integrations instead of dd-agent
|
Looks good to me apart from my small comments. |
tmichelet
force-pushed
the
tristan/integrations-recipe
branch
from
340c7d0 to
557232a
Compare
olivielpeau
force-pushed
the
tristan/integrations-recipe
branch
from
557232a to
f3b788f
Compare
- Let the datadog:dd-agent recipe install any package found in the `extra_packages` attribute, and configure it - add some tests with the twemproxy integration
olivielpeau
force-pushed
the
tristan/integrations-recipe
branch
from
f3b788f to
9bfa20f
Compare
|
Rebased and added specs. This should be ready for a final review/merge. |
|
LGTM |
| end | ||
|
|
||
| if @agent_check_dir | ||
| describe file('/opt/datadog-agent/3rd-party/twemproxy/check.py') do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extra_packagesattribute, and configure itcc @miketheman