-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add the possibility to prevent the zypper repository installation #452
Conversation
This can be useful in an environment where the use of public repository is not allowed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thank you very much for submitting this PR! It looks good, but I have a suggestion for changing the naming of the variable. When you fix that, I can merge.
defaults/main.yml
Outdated
@@ -100,6 +100,9 @@ datadog_ignore_old_centos_python3_error: false | |||
# Use the datadog_zypper_repo variable to override the repository used. | |||
datadog_zypper_repo: "" | |||
|
|||
# Define if the official zypper Datadog repository services should be installed | |||
datadog_zypper_repo_enabled: yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you rename this to datadog_manage_zypper_repo
? The enabled
keyword is a repofile keyword and it might the variable name confusing. Additionally, we already have a variable called datadog_manage_config
, so using datadog_manage_zypper_repo
would be consistent with that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, even better might be datadog_manage_zypper_repofile
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I changed the variable name according to your suggestion.
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, merging. Thanks a lot for the contribution!
This can be useful in an environment where the use of public repository is not allowed.