Feat: add the possibility to prevent the zypper repository installation #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be useful in an environment where the use of public repository is not allowed.
bkabrda
suggested changes
Aug 15, 2022
defaults/main.yml
Outdated
| @@ -100,6 +100,9 @@ datadog_ignore_old_centos_python3_error: false | |||
| # Use the datadog_zypper_repo variable to override the repository used. | |||
| datadog_zypper_repo: "" | |||
|
|
|||
| # Define if the official zypper Datadog repository services should be installed | |||
| datadog_zypper_repo_enabled: yes | |||
There was a problem hiding this comment.
Could you rename this to datadog_manage_zypper_repo? The enabled keyword is a repofile keyword and it might the variable name confusing. Additionally, we already have a variable called datadog_manage_config, so using datadog_manage_zypper_repo would be consistent with that.
There was a problem hiding this comment.
Actually, even better might be datadog_manage_zypper_repofile.
There was a problem hiding this comment.
Hi, I changed the variable name according to your suggestion.
Thanks.
bkabrda
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be useful in an environment where the use of public repository is not allowed.