Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Jay-Mo-99] Week 04 #832

Merged
merged 2 commits into from
Jan 5, 2025
Merged

[Jay-Mo-99] Week 04 #832

merged 2 commits into from
Jan 5, 2025

Conversation

Jay-Mo-99
Copy link
Contributor

@Jay-Mo-99 Jay-Mo-99 commented Jan 2, 2025

답안 제출 문제

체크 리스트

  • 우측 메뉴에서 PR을 Projects에 추가해주세요.
  • Projects의 오른쪽 버튼(▼)을 눌러 확장한 뒤, Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 StatusIn Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@Jay-Mo-99 Jay-Mo-99 added the py label Jan 2, 2025
@Jay-Mo-99 Jay-Mo-99 requested a review from rivkode January 2, 2025 22:55
@Jay-Mo-99 Jay-Mo-99 self-assigned this Jan 2, 2025
@Jay-Mo-99 Jay-Mo-99 requested a review from a team as a code owner January 2, 2025 22:55
@Jay-Mo-99 Jay-Mo-99 changed the title [Jay-Mo-99] Week 04 solutions [Jay-Mo-99] Week 04 Jan 2, 2025
Comment on lines +29 to +30
# Sort the list
nums.sort()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sort를 사용하지 않고 dict 을 사용해서 i를 인덱스로 사용해보는 방법은 어떨까요 ? 만약 숫자의 크기가 커진다면 정렬하는 것도 시간복잡도가 커질수 있다고 생각해서요!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

예 sort는 Timsort 방식이라 무조건 nO(log n)) 시간 복잡도인게 아쉬웠었는데 다음에는 dict도 한번 사용해보겠습니다.

Copy link
Member

@rivkode rivkode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전체적으로 깔끔하게 너무 잘 해주셨습니다! 문제를 보고 정리하는 부분 잘 배워갑니다 ㅎㅎ 수고하셨습니다~
아직 풀이중이셔서 오늘 오후에 추가될 경우 시간이 되면 볼 수 있도록 하겠습니다~

@SamTheKorean SamTheKorean merged commit 3b55fd8 into DaleStudy:main Jan 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

3 participants