[rivkode] Week4 #831
Merged
[rivkode] Week4 #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taewanseoul
reviewed
Jan 3, 2025
Comment on lines
+17
to
+31
| # 두 리스트를 순회하며 병합 | ||
| while list1 and list2: | ||
| if list1.val <= list2.val: | ||
| current.next = list1 | ||
| list1 = list1.next | ||
| else: | ||
| current.next = list2 | ||
| list2 = list2.next | ||
| current = current.next | ||
|
|
||
| # 남아 있는 노드 처리 | ||
| if list1: | ||
| current.next = list1 | ||
| elif list2: | ||
| current.next = list2 |
There was a problem hiding this comment.
# 두 리스트를 순회하며 병합 부분을 수정해서 # 남아 있는 노드 처리 부분을 제거할 수 있게끔 수정해 보는 것도 나쁘지 않을 것 같습니다~
There was a problem hiding this comment.
@taewanseoul 안녕하세요 ! 리뷰 남겨주셔서 감사합니다.
혹시 그럼 남아있는 노드를 제거 하기 위해서 저 if else 부분을 while문에 같이 넣는 방법일까요 ?
로직 순서를 말씀하신건지 혹은 아예 저 남아있는 노드 처리 부분을 없애고 다른 방법을 찾아보는건지 궁금합니다 ㅎㅎ
SamTheKorean
approved these changes
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
체크 리스트
In Review로 설정해주세요.