feat(core): customizable Chromium executable path #9670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also build Chromium-bundled Docker image for arm/arm64 Signed-off-by: Rongrong <i@rong.moe>
Signed-off-by: Rongrong <i@rong.moe>
Rongronggg9
force-pushed
the
custom-chromium-path
branch
from
4037db0 to
8df5e48
Compare
|
It seems that the build caching issue still occurs from time to time. It should be a weird upstream issue so we can do nothing but only wait for upstream to fix it: moby/buildkit#2822 (comment) But don't worry, this PR won't make it worse since the build flow of the ordinary image, whose cache goes into The build flow of the Chromium-bundled image can still re-use all caches from the ordinary build and from inline caches within the previous pushed image (inline cache seems not affected by the issue). Typical cache-all-hit build time is <40s, cache-miss build time is ~4.5min. |
TonyRL
reviewed
May 1, 2022
Signed-off-by: Rongrong <i@rong.moe>
Signed-off-by: Rongrong <i@rong.moe>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
该 PR 相关 Issue / Involved issue
Close #
完整路由地址 / Example for the proposed route(s)
新 RSS 检查列表 / New RSS Script Checklist
Puppeteer说明 / Note