Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build):change npm ci to yarn #8716

Merged
merged 2 commits into from
Jan 8, 2022
Merged

fix(build):change npm ci to yarn #8716

merged 2 commits into from
Jan 8, 2022

Conversation

RikkaBlue
Copy link
Contributor

@RikkaBlue RikkaBlue commented Dec 12, 2021 •
edited
Loading

该 PR 相关 Issue / Involved issue

Close #8715

完整路由地址 / Example for the proposed route(s)

NOROUTE

新RSS检查列表 / New RSS Script Checklist

  • New Route
  • Documentation
    • CN
    • EN
  • 全文获取 fulltext
    • Use Cache
  • 反爬/频率限制 anti-bot or rate limit?
    • 如果有, 是否有对应的措施? If yes, do your code reflect this sign?
  • 日期和时间 date and time
    • 可以解析 Parsed
    • 时区调整 Correct TimeZone
  • 添加了新的包 New package added
  • Puppeteer

说明 / Note

顺便改了一下 Dockerfile 的命令顺序，在仅更改路由而不改动 package.json 的情况下，利用缓存 Docker 层的优势1

Footnotes

  1. Building Efficient Dockerfiles - Node.js ↩

@vercel
Copy link

vercel bot commented Dec 12, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/diy/rsshub/FTSCDDC7By9zwuHRpqRpHN8DrTm5
✅ Preview: https://rsshub-git-fork-rikkablue-dockerfix-diy.vercel.app

@RikkaBlue RikkaBlue changed the title change npm ci to yarn fix(build):change npm ci to yarn Dec 12, 2021
SukkaW
SukkaW approved these changes Dec 12, 2021
View reviewed changes
Copy link
Contributor

@SukkaW SukkaW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

TonyRL
TonyRL reviewed Dec 12, 2021
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@RikkaBlue @TonyRL
Remove unused command
b0d62ad 
Co-authored-by: Tony <TonyRL@users.noreply.github.com>
@github-actions
Copy link
Contributor

自动检测失败, 请确认PR正文部分符合格式规范并重新开启, 详情请检查日志
Auto Route test failed, please check your PR body format and reopen pull request. Check logs for more details

@github-actions github-actions bot added the Auto: Route No Found Automatic test failed to test route in PR body label Dec 12, 2021
@github-actions github-actions bot closed this Dec 12, 2021
@NeverBehave
Copy link
Collaborator

@SukkaW 所以又为啥换成了yarn

@NeverBehave NeverBehave reopened this Dec 17, 2021
@AgFlore
Copy link
Contributor

AgFlore commented Dec 17, 2021

@SukkaW 所以又为啥换成了yarn

大概要问 @DIYgod
483ae45
6e10cb5

@SukkaW
Copy link
Contributor

SukkaW commented Dec 17, 2021

@SukkaW 所以又为啥换成了yarn

问我干嘛。换我，我肯定用 pnpm-lock.yaml 啊

This was referenced Dec 28, 2021
Merged
Merged
@KTachibanaM
Copy link
Contributor

Is there activity on this MR? My MR seems to be blocked on this one. Thanks.

@NeverBehave NeverBehave merged commit b36b326 into DIYgod:master Jan 8, 2022
gadflysu pushed a commit to gadflysu/RSSHub that referenced this pull request Jan 29, 2022
@RikkaBlue @gadflysu
fix(build):change npm ci to yarn (DIYgod#8716)
41f965b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TonyRL TonyRL TonyRL left review comments

@SukkaW SukkaW SukkaW approved these changes

Assignees
No one assigned
Labels
Auto: Route No Found Automatic test failed to test route in PR body core enhancement
Projects
None yet
Milestone
No milestone
6 participants
@RikkaBlue @NeverBehave @AgFlore @SukkaW @KTachibanaM @TonyRL