Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 更改 B站嵌入方式来防止误点会导致跳转 B站 #14517

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

sherlcok314159
Copy link
Contributor

Involved Issue / 该 PR 相关 Issue

该 PR 是为了提升 B站视频嵌入的观看,之前的嵌入方式,会很容易发起跳转到 B站,比如点击视频就会
PR 中的方式可以避免这种情况的发生,更加简洁

Example for the Proposed Route(s) / 路由地址示例

NOROUTE

@github-actions github-actions bot added Route: v2 v2 route related Auto: Route Test Skipped PR involves no routes labels Feb 21, 2024
Copy link
Collaborator

@TonyRL TonyRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But users will lose volume control, playback speed control and quality control.

@sherlcok314159
Copy link
Contributor Author

Not really. The volume can be controlled. And the original iframe can not change the speed. When you click the speed, you are transferred to bilibili.com. Whenever the iframe is created, it is of the best quality. When you want a higher quality, you are transferred to bilibili.com and must log in.

@TonyRL TonyRL changed the title 更改 B站嵌入方式来防止误点会导致跳转 B站 fix: 更改 B站嵌入方式来防止误点会导致跳转 B站 Feb 23, 2024
@TonyRL TonyRL merged commit a1bb675 into DIYgod:master Feb 23, 2024
69 of 71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto: Route Test Skipped PR involves no routes Route: v2 v2 route related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants