Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local tracker encoding fix #281

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Local tracker encoding fix #281

merged 3 commits into from
Jul 23, 2024

Conversation

skrawcz
Copy link
Contributor

@skrawcz skrawcz commented Jul 21, 2024

The local tracker was encoding writes, but not reads. This fixes #273.

On different python systems, the default encoding is different, and thus we
weren't consistent here.

This change makes sure all local tracker reads and writes use the utf-8 encoding.
We also skip character errors where appropriate.

Changes

  • local tracker
  • docs
  • local tracker test

How I tested this

  • locally
  • user tested RC version.

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

skrawcz added 3 commits July 20, 2024 11:09
To make it clear what we assume.
Adds test cases to:

1. enshrine behavior that developer needs to make sure things are utf-8 encodable.
2. integration test to ensure what is written can be read.
@skrawcz skrawcz requested a review from elijahbenizzy July 21, 2024 17:24
@skrawcz skrawcz linked an issue Jul 21, 2024 that may be closed by this pull request
@skrawcz skrawcz merged commit 3e7b77a into main Jul 23, 2024
11 checks passed
@skrawcz skrawcz deleted the encoding_fisx branch July 23, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnicodeDecodeError when reading from local tracker log.jsonl
1 participant