Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add global buttons to base menus #5683

Merged
merged 9 commits into from
Oct 12, 2022
Merged

Add global buttons to base menus #5683

merged 9 commits into from
Oct 12, 2022

Conversation

TrustyJAID
Copy link
Member

@TrustyJAID TrustyJAID commented Apr 15, 2022 •
edited by Kowlin
Loading

Description of the changes

This adds a bot setting for using buttons which is also used by cores menus util.

This is blocked by #5634

Have the changes in this PR been tested?

Yes

@github-actions github-actions bot added Category: Bot Core Category: Core - API - Utils Package This is related to stuff in `redbot.core.utils` labels Apr 15, 2022
@TrustyJAID TrustyJAID added the Blocked By: Other PR Blocked by another PR. label Apr 15, 2022
@TrustyJAID
Actually change the setting
a19586c
@TrustyJAID
no, this setting
59f331a
@TrustyJAID
Controls are now optional so I can pass None, Store the views by thei…
b622010 
…r message ID rather than ctx.message ID so one could create multiple menus in the same context without waiting for the first one to finish
@TrustyJAID
Try to avoid help sending two menus at once with conflicting settings
ee8a5a2
@Kowlin Kowlin self-assigned this Oct 11, 2022
@Kowlin Kowlin removed the Blocked By: Other PR Blocked by another PR. label Oct 12, 2022
@github-actions github-actions bot added the Category: Docs - Other This is related to documentation that doesn't have its dedicated label. label Oct 12, 2022
@Kowlin Kowlin merged commit b0a3f00 into Cog-Creators:V3/develop Oct 12, 2022
@red-githubbot red-githubbot bot added the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label Oct 12, 2022
@Kreusada Kreusada mentioned this pull request Oct 21, 2022
Merged
@karlsbjorn karlsbjorn mentioned this pull request Oct 21, 2022
Merged
Drapersniper pushed a commit to Drapersniper/Red-DiscordBot that referenced this pull request Nov 27, 2022
@TrustyJAID @Kowlin @Drapersniper
Add global buttons to base menus (Cog-Creators#5683)
b836619 
Co-authored-by: Kowlin <10947836+Kowlin@users.noreply.github.com>
Drapersniper pushed a commit to Drapersniper/Red-DiscordBot that referenced this pull request Dec 2, 2022
@TrustyJAID @Kowlin @Drapersniper
Add global buttons to base menus (Cog-Creators#5683)
2668257 
Co-authored-by: Kowlin <10947836+Kowlin@users.noreply.github.com>
@Flame442 Flame442 added Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. and removed Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. labels Apr 30, 2023
@github-actions github-actions bot added Category: Core - Bot Class This is related to the `redbot.core.bot.Red` class. Category: Core - Bot Commands This is related to core commands (Core and CogManagerUI cog classes). and removed Category: Docs - Other This is related to documentation that doesn't have its dedicated label. labels Apr 30, 2023
@Jackenmen Jackenmen added this to the 3.5.0 milestone May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phenom4n4n phenom4n4n phenom4n4n left review comments

@Kowlin Kowlin Kowlin approved these changes

Assignees

@Kowlin Kowlin

Labels
Category: Core - API - Utils Package This is related to stuff in `redbot.core.utils` Category: Core - Bot Class This is related to the `redbot.core.bot.Red` class. Category: Core - Bot Commands This is related to core commands (Core and CogManagerUI cog classes). Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR.
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@TrustyJAID @Kowlin @phenom4n4n @Jackenmen @Flame442