Add util functions extracting end_user_data_statement directly from cog's info.json
#4404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TurnrDev
previously approved these changes
Sep 7, 2020
|
I'm a fan of anything that means I don't have to store the same text twice. |
Jackenmen
reviewed
Sep 7, 2020
Jackenmen
added
Category: Core - API - Utils Package
Jackenmen
requested changes
Sep 19, 2020
There was a problem hiding this comment.
Aside from various grammar stuff and other small issues that I pointed out in review comments, the methods are called get_end_user_statement rather than get_end_user_data_statement which doesn't make that much sense when you read it (as in: it's a statement about end user data, not statement about end user). If you think that it's too long name, I guess we could also call it get_eud_statement, although I'm not really all that convinced that it's a good name.
Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
|
This should now be ready to merge |
Jackenmen
changed the title
end_user_data_statement directly from their info.jsonend_user_data_statement directly from cog's info.json
Cog-CreatorsBot
added
the
Changelog Entry: Pending
Jackenmen
added
Changelog Entry: Added
Drapersniper
added
the
QA: Passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description of the changes
here is an example usage of this new util.
This util will attempt to read the statement directly from the cogs
info.jsonand if not successfull it will log a meaningful message to the user letting them know its not possible to do so and at that point it will returnNoneso that the default handling will be handed back to Red (It will mention that this cog does not have an end user data statement in the[p]3rdpartycommand).