Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill DataConverter #2554

Merged
merged 2 commits into from
Apr 9, 2019
Merged

Kill DataConverter #2554

merged 2 commits into from
Apr 9, 2019

Conversation

mikeshardmind
Copy link
Contributor

With changes to config, the converter from V2 data is no longer safe for use. (see #2545, #2550, #2551, #2536)for the final nails in the coffin, was already unsafe for use with large datasets)

This can be rewritten at a later date more up to date with newer methods of doing things in Config, but the current version is broken in multiple ways.

  1. It attempts to write each entry individually: This will disconnect some bots currently with a blocked heartbeat. This cannot be fixed by context switching between writes without the potential for data loss.
  2. It has no awareness of the new custom groups, and cannot have that awareness without a large re-design.
  3. The inner workings of it were written hastily, and while they are correct in the transformative process, they are not readily maintainable.

1 & 3 are failings on my part, 2 is a result of changes unforeseen at the time.

This removes the cog and related util, and leaves the door open to anyone wishing to rewrite this up to our current code standards.

End users can still convert data so long as they do so prior to the 3.1 release, but I'd suggest leaving the v2 data behind from here.

@tekulvw tekulvw merged commit 136e781 into Cog-Creators:V3/develop Apr 9, 2019
fixator10 added a commit to fixator10/Fixator10-Cogs that referenced this pull request Apr 11, 2019
DataConverter does not exists anymore: Cog-Creators/Red-DiscordBot#2554
@mikeshardmind mikeshardmind deleted the kill-dataconverter branch December 26, 2019 17:01
@Jackenmen Jackenmen added this to the 3.1.0 milestone Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants