Finish and Refactor Predicate Utility #2169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use classmethods to create predicates directly * Some predicates assign a `result` to the predicate object on success * Add ReactionPredicate equivalent * Add `utils.menus.start_adding_reactions` * Add documentation for predicates module * Use new utils throughout the core bot Happened to also find some bugs in places, and places where we were waiting for events without catching asyncio.TimeoutError... * Rename `match` attribute to `result`.
Tobotimus
requested review from
palmtree5,
tekulvw and
Twentysix26
as code owners
This attribute should always be an empty string Signed-off-by: Toby Harradine <tobyharradine@gmail.com>
|
Holy crap dude. This is amazing. I can't believe you took my tiny enhancement and turned it into this robust utility. I'm currently going through all of the methods testing them separately, and then checking the implementation applied to core. Also the documentation is 💯 . |
Redjumpman
suggested changes
Oct 5, 2018
|
@Redjumpman Thanks for reviewing 😃 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resultto the predicate object on successReactionPredicateequivalent toMessagePredicateutils.menus.start_adding_reactions, a non-blocking method for adding reactions asynchronouslyHappened to also find some bugs in places, and places where we were waiting for events without catching
asyncio.TimeoutError