Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: z-index in top-nav file #238

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

abdtriedcoding
Copy link

Description

When scrolling through the homepage on the Badget site, it's evident that certain elements overlap the navbar, resulting in a suboptimal user experience. This issue stems from a z-index problem within the navbar component. To enhance the appearance and functionality of the marketing page, I've addressed this issue by adjusting the z-index values in the top-nav file. The fix ensures that elements no longer obscure the navbar while scrolling, thereby improving the overall aesthetics and usability of the page.

What type of PR is this? (check all applicable)

  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Fixes #237

Mobile & Desktop Screenshots/Recordings

Screenshot 2024-04-27 140247
Screenshot 2024-04-27 140358

Steps to QA

  1. Go to the Badget site's homepage page.
  2. Scroll down the page.
  3. Verify that no elements overlap the navbar.
  4. Test the behavior on different screen sizes (if applicable).
  5. Check for any other visual or functional issues related to the navbar.
  6. Ensure that the navbar remains responsive and functional across various devices and browsers.

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

Copy link

vercel bot commented Apr 27, 2024

@abdtriedcoding is attempting to deploy a commit to the Salgsmaskin Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
badget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 4:21am

Copy link
Owner

@Codehagen Codehagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! ✨

@Codehagen Codehagen merged commit 3613edb into Codehagen:main Apr 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: z-index issue causing overlapping elements on marketing page navbar
2 participants