Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: github actions to deploy to vercel #212

Merged
merged 1 commit into from
Mar 14, 2024
Merged

ci: github actions to deploy to vercel #212

merged 1 commit into from
Mar 14, 2024

Conversation

matteobad
Copy link

@matteobad matteobad commented Mar 13, 2024

Description

As of right now, @meglerhagen is the only one who can trigger a deployment on Vercel and the only one with access to it. Rightfully so since it's his account, but this is slowing us down in approving, testing, and merging PRs.
With this PR I've added two new GitHub Actions:

  • Preview Vercel -> deploy on preview
  • Production Vercel -> deploy on prod

The idea is to trigger deployment from GA so that @meglerhagen's Vercel account remains private, but we can make CICD faster and with fewer manual steps.

What type of PR is this? (check all applicable)

  • [] 💡 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Steps to QA

  1. Open a PR
  2. Deployment on Vercel Preview should be triggered from GA
  3. Merge the PR
  4. Deployment on Vercel Production should be triggered from GA

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

These ENV need to be added to GitHub secrets and are required for the new Actions to work:

  • VERCEL_PROJECT_ID
  • VERCEL_ORG_ID
  • VERCEL_TOKEN

Notes

@matteobad matteobad self-assigned this Mar 13, 2024
Copy link

vercel bot commented Mar 13, 2024

@matteobad is attempting to deploy a commit to the Salgsmaskin Team on Vercel.

A member of the Team first needs to authorize it.

@matteobad matteobad requested a review from Codehagen March 14, 2024 11:42
@Codehagen
Copy link
Owner

Trying to merge it now @matteobad
image

@Codehagen Codehagen merged commit 774e71a into Codehagen:main Mar 14, 2024
3 of 4 checks passed
@Codehagen
Copy link
Owner

image

@matteobad matteobad deleted the feature/ci-vercel-deployment branch March 14, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants