Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: transaction modal implementation #209

Merged
merged 11 commits into from
Mar 13, 2024
Merged

Feature: transaction modal implementation #209

merged 11 commits into from
Mar 13, 2024

Conversation

ousszizou
Copy link

@ousszizou ousszizou commented Mar 12, 2024 •
edited
Loading

Description

  • Modal Addition: Implemented the modal component to add transactions.
  • Combobox Enhancements: Updated the Combobox component to enable users to add new categories directly through the UI, making it more flexible and user-friendly.
  • Component Reusability: Made improvements to previously developed components to increase their reusability across the application.

What type of PR is this? (check all applicable)

  • 💡 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Closes #204

Mobile & Desktop Screenshots/Recordings

Steps to QA

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@vercel Vercel
Copy link

vercel bot commented Mar 12, 2024

@ousszizou is attempting to deploy a commit to the Salgsmaskin Team on Vercel.

A member of the Team first needs to authorize it.

@Codehagen Codehagen requested a review from alexghirelli March 12, 2024 09:37
alexghirelli
alexghirelli approved these changes Mar 13, 2024
View reviewed changes
apps/www/components/new-dashboard/components/dashboard-1.tsx
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why you created a new dashboard component?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL because the merge conflicts, so somehow my IDE kept this unused file. no need for it at all, should be removed.

@Codehagen Codehagen merged commit 4d37ec8 into Codehagen:main Mar 13, 2024
3 of 4 checks passed
@ousszizou ousszizou deleted the feature/transaction-modal-implementation branch March 13, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexghirelli alexghirelli alexghirelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Transaction Handling Modal Implementation
3 participants
@ousszizou @alexghirelli @Codehagen