Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/UI cleanup #208

Merged
merged 5 commits into from
Mar 12, 2024
Merged

Feature/UI cleanup #208

merged 5 commits into from
Mar 12, 2024

Conversation

matteobad
Copy link

Description

  • TopNav + Footer common for all pages
  • SideNav common from all pages (not duplicated anymore)
  • Every main "feature" of the app will have its main page (on the sidenav)
  • Every main "feature" of the app can have subpages (button on the middle of the page)
  • URL match active page/subpage

In this way, the menu feels easier to navigate but we keep all of the features and pages. We are just grouping them by category, no feature or pages are lost and every layout/component can be reused. No needless code duplication anymore

What type of PR is this? (check all applicable)

  • 💡 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Fixes: #194
Fixes: #190
Fixes: #14

Mobile & Desktop Screenshots/Recordings

image

Steps to QA

  1. Deploy to Preview
  2. Navigate all of the pages
  3. Validate you see the thing working

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

@matteobad matteobad requested a review from Codehagen March 10, 2024 12:18
Copy link

vercel bot commented Mar 10, 2024

@matteobad is attempting to deploy a commit to the Salgsmaskin Team on Vercel.

A member of the Team first needs to authorize it.

@matteobad matteobad added the 🖌️ frontend Improvements for the ui label Mar 10, 2024
@matteobad matteobad modified the milestones: Alpha 0.1, Frontend Mar 10, 2024
Copy link

@alexghirelli alexghirelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Codehagen Codehagen merged commit 6550a1c into Codehagen:main Mar 12, 2024
3 of 4 checks passed
@matteobad matteobad deleted the feature/ui-cleanup branch March 12, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖌️ frontend Improvements for the ui
Projects
None yet
3 participants