-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create onboarding template #207
Conversation
@shouryan01 is attempting to deploy a commit to the Salgsmaskin Team on Vercel. A member of the Team first needs to authorize it. |
I understand that some ui elements might be too flashy and unnecessary, like the connect account animation. Let me know how to refine this flow and add/remove pages |
@alexghirelli - Do you want to review it? Since it prob you that is going to make the stitch with the Backend? |
@shouryan01 your design looks good, it's just that there is too much empty space. |
I'll check it asap |
The UI it's pretty amazing in dark mode. I'm thinking that we can always force the dark mode into this section in order to make work properly the animation in the background. I love the animation when you hover the button "connect account", but I don't like so much the shadow under the button. Can we remove it or reduce the size? Another thing to consider. Since we are added the possibility for the user to add accounts and assets manually, we have to consider in the onboarding process also this things. So, we can add one or two more button along with "connect account" button that will be useful to add an account manually and to add an asset manually. cc. @meglerhagen @matteobad |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the comment above.
Thanks @alexghirelli for the comments, I'll make these changes. @piyusharmap, I tried out your suggestion of modals, but it looks unconventional on a mobile-sized display |
What if we apply a blur effect to the boundaries of the animation when hovering over the 'Connect Account' button, in order to blend it with the background? Currently, it feels too boxy. |
Can be an idea |
@alexghirelli review please! |
I will review it today @shouryan01 @meglerhagen |
@shouryan01 Do you want to stitch this to the be, also tried to send you a message on Discord β¨ |
I can take this ticket next week, in the meantime if anyone needs work they are free to take it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Starts the template for the onboarding flow for new users
What type of PR is this? (check all applicable)
Related Tickets & Documents
#196
Mobile & Desktop Screenshots/Recordings
Steps to QA
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?