Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic dialogs based on selections #185

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Dynamic dialogs based on selections #185

merged 3 commits into from
Mar 4, 2024

Conversation

ousszizou
Copy link

@ousszizou ousszizou commented Feb 29, 2024

Description

  • Implement the single modal structure in the codebase.
  • Develop the logic for dynamically displaying form inputs based on Account Type.
  • Integrate animations for transitioning between form steps.
  • Adjust the data model if necessary to accommodate the unified input structure.

What type of PR is this? (check all applicable)

  • 💡 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Close #166

Mobile & Desktop Screenshots/Recordings

Steps to QA

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Copy link

vercel bot commented Feb 29, 2024

@ousszizou is attempting to deploy a commit to the Salgsmaskin Team on Vercel.

A member of the Team first needs to authorize it.

@ousszizou ousszizou marked this pull request as ready for review March 2, 2024 21:27
@Codehagen Codehagen requested a review from matteobad March 3, 2024 13:53
Copy link

vercel bot commented Mar 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
badget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2024 6:23pm

@Codehagen Codehagen requested a review from alexghirelli March 4, 2024 18:20
@Codehagen
Copy link
Owner

@alexghirelli - Going to merge this now. Can you handle the input to the DB?

Copy link
Owner

@Codehagen Codehagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Merging now! ✨

@Codehagen Codehagen self-requested a review March 4, 2024 18:34
@Codehagen Codehagen merged commit 7909fd8 into Codehagen:main Mar 4, 2024
5 checks passed
@Codehagen
Copy link
Owner

Great Work, but could we also add these features @ousszizou ?

Is it possible to adjust the number formatting to include a space between each set of three digits (thousand separators)? This change would enhance readability for users, helping them quickly grasp the value presented.

Could we transform the number format from the current representation?
image

To a more user-friendly format with spaces (link to the second image)?
image

Additionally, for consistency and improved user experience, can we add a "Name" input field at the top of all related interfaces ✨
image

Tasks

  • Adjust the number formatting to include a space between each set of three digits (thousand separators) to enhance readability.
  • Add a "Name" input field at the top of all related interfaces for consistency and improved user experience.

@ousszizou
Copy link
Author

Yeaa for sure. I'll work on that today.

@Codehagen
Copy link
Owner

Thanks! If you want to raise a new PR you can do that :)

@ousszizou
Copy link
Author

Definitely! that's what Am going to do.

@ousszizou ousszizou deleted the dynamic-dialogs-based-on-selections branch March 5, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Dynamic Dialog Opening Based on Radio Button Selection
2 participants