Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat enhanced type safety for Real Estate form #178

Merged

Conversation

chetra-seng
Copy link

@chetra-seng chetra-seng commented Feb 28, 2024

Description

What type of PR is this? (check all applicable)

  • πŸ’‘ Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Steps to QA

Added to documentation?

  • πŸ“œ README.md
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Copy link

vercel bot commented Feb 28, 2024

@chetra-seng is attempting to deploy a commit to the Salgsmaskin Team on Vercel.

A member of the Team first needs to authorize it.

@chetra-seng chetra-seng marked this pull request as draft February 28, 2024 08:43
@chetra-seng chetra-seng marked this pull request as ready for review February 28, 2024 08:47
@chetra-seng
Copy link
Author

@meglerhagen Can you review this pr? πŸ˜„

@matteobad
Copy link

@chetra-seng fine by be. Just take a look at the typecheck command please

@chetra-seng
Copy link
Author

thanks @matteobad, typecheck command run fine locally. Not sure why it failed on ci tho. I'll looking further into this.

@matteobad
Copy link

matteobad commented Feb 29, 2024

LGBM ;)
@meglerhagen can you merge this?

@Codehagen Codehagen merged commit 1062141 into Codehagen:main Feb 29, 2024
3 of 4 checks passed
@Codehagen
Copy link
Owner

MERGED! ✨

@chetra-seng
Copy link
Author

Thanks @meglerhagen for getting my first open source Pr merged. I'm so excited for next upcoming issues and features ✨✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants