Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/134 gocardless connector #157

Merged
merged 23 commits into from
Feb 29, 2024
Merged

Feature/134 gocardless connector #157

merged 23 commits into from
Feb 29, 2024

Conversation

matteobad
Copy link

@matteobad matteobad commented Feb 19, 2024 •
edited
Loading

Description

  • feat: created GoCardless Connector
  • feat: added CRON to upsert Integration from all available Connector
  • feat: added CRON to upsert Account, Balance and Transaction for all active Resource
  • refactor: connector core logic for an easier development
  • refactor: DB schema into openbanking and provider
  • docs: add bruno collection to trigger CRON

What type of PR is this? (check all applicable)

  • 💡 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Fixes #134

Steps to QA

  1. Upgrade DB schema pnpm run db:push
  2. Seed DB with SANDBOX data pnpm run db:seed
  3. Validate you see the mock data into the DB
  4. Create CRON_SECRET env https://dev.to/chrisnowicki/how-to-secure-vercel-cron-job-routes-in-nextjs-13-9g8
  5. Test CRON on Vercel

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

matteobad and others added 11 commits February 13, 2024 23:59
@matteobad
feat: add connector list api and config form
7eb5418
@matteobadini
ci: add planetscale deploy request action
838eb52
@Codehagen @matteobad
feat: update default layout for dashboard panels (#143)
cd03e66 
The default layout for the Transactions, Accounts, Dashboard, Recurring, and Categories dashboards has been updated. The previous default layout values [265, 440, 655] have been changed to [20, 40, 40]. This change was made to improve the initial layout and make it more visually appealing for users.
@matteobad
Merge branch '137-dynamic-connector-data' into feature/134-gocardless…
2d4f43e 
…-connector
@matteobad
Merge branch 'main' into feature/134-gocardless-connector
66bbf3d
@matteobad
WIP
c246f6a
@matteobad
WIP
f88a73d
@matteobad
WIP
89d97c0
@matteobad
WIP
e36dde0
@matteobad
fix: country and currency seed
4f722f2
@matteobad
working gocardless import data
51bcdbe
@vercel Vercel
Copy link

vercel bot commented Feb 19, 2024

@matteobad is attempting to deploy a commit to the Salgsmaskin Team on Vercel.

A member of the Team first needs to authorize it.

@matteobad matteobad added 💡 feature Requests for new features or enhancements. 🧙 backend labels Feb 20, 2024
@matteobad matteobad added this to the Open Banking milestone Feb 20, 2024
@matteobad matteobad marked this pull request as ready for review February 27, 2024 17:49
alexghirelli
alexghirelli approved these changes Feb 28, 2024
View reviewed changes
Copy link

@alexghirelli alexghirelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@Codehagen
Copy link
Owner

Looks good @matteobad - But i see that we have some conflicts
image

Codehagen
Codehagen requested changes Feb 28, 2024
View reviewed changes
Copy link
Owner

@Codehagen Codehagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we have some conflicts that needs to be sorted out. Cant wait ✨

@matteobad
Copy link
Author

We MUST also merge the deploy request on DB. I can take care of that tomorrow for sure!

@Codehagen
Copy link
Owner

Sounds good @matteobad - Tell me when the DB is updated and i can merge this ✨

@alexghirelli
Copy link

Sounds good @matteobad - Tell me when the DB is updated and i can merge this ✨

I'm waiting for the merge because the refactor to the database tables for me is critical to be able to proceed and finish the API for manual entry. Thanks guys

@matteobad
Copy link
Author

Successfully updated and seeded the DB

@Codehagen Codehagen merged commit d36abec into Codehagen:main Feb 29, 2024
3 of 4 checks passed
@matteobad matteobad mentioned this pull request Mar 6, 2024
Closed
@matteobad matteobad deleted the feature/134-gocardless-connector branch March 12, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Codehagen Codehagen Codehagen requested changes

@alexghirelli alexghirelli alexghirelli approved these changes

Assignees
No one assigned
Labels
🧙 backend 💡 feature Requests for new features or enhancements.
Projects
None yet
Milestone
Open Banking
Development

Successfully merging this pull request may close these issues.

GoCardless connector
4 participants
@matteobad @Codehagen @alexghirelli @matteobadini