ISBNdb Plugin #265
Merged
ISBNdb Plugin #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardslabs
reviewed
Apr 17, 2017
plugins/isbn.py
Outdated
| @@ -0,0 +1,45 @@ | |||
| import re | |||
| import json, requests | |||
There was a problem hiding this comment.
You shouldn't need to import json as requests has a built in json method.
edwardslabs
reviewed
Apr 17, 2017
plugins/isbn.py
Outdated
| url = url + book | ||
| #print(url) | ||
| resp = requests.get(url=url) | ||
| data = json.loads(resp.text) |
There was a problem hiding this comment.
this could be changed to
data = resp.json()
|
yup, But It still requires json module for getting dict from json str.
2017/04/18 午前7:10 "Andy Edwards" <notifications@github.com>:
… ***@***.**** commented on this pull request.
------------------------------
In plugins/isbn.py
<#265 (comment)>:
> +import cloudbot
+
***@***.***_start()
+def load_api(bot):
+ global isbndb_key
+ global cx
+
+ isbndb_key = bot.config.get("api_keys", {}).get("isbndb_dev_key", None)
+
+def getISBN(book):
+ try:
+ url = "http://isbndb.com/api/v2/json/{}/book/".format(isbndb_key)
+ url = url + book
+ #print(url)
+ resp = requests.get(url=url)
+ data = json.loads(resp.text)
this could be changed to
data = resp.json()
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#265 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALa_EzGWXCXf1LElNvFgA-yqYij05iifks5rw-NmgaJpZM4M5X4B>
.
|
|
Requests has that built in though, with the |
Removed the json library from requirements.txt as it is not required.
|
I just pushed an update using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a plugin to allow users to type ".isbn " and return information about the book from http://isbndb.com.