Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update irc.py #208

Merged
merged 2 commits into from
Nov 5, 2015
Merged

Update irc.py #208

merged 2 commits into from
Nov 5, 2015

Conversation

Red-M
Copy link
Contributor

@Red-M Red-M commented Oct 26, 2015

resubmitting to branch as per #190.

@Red-M
Update irc.py
e9100d1 
resubmitting to branch as per CloudBotIRC#190.
@TheReverend403
Copy link

You forgot to set content_raw. Failure to do so results in an AttributeError on line 376

if event_type is EventType.message and content_raw.count("\x01") >= 2 and content_raw.startswith("\x01"):

See https://github.com/TheReverend403/CloudBot/commit/5328d2d3ee1d320f402a22884166af759b207402

dmptrluke added a commit that referenced this pull request Nov 5, 2015
@dmptrluke
Merge pull request #208 from Red-M/patch-9
c8ceede 
Update irc.py
@dmptrluke dmptrluke merged commit c8ceede into CloudBotIRC:python3.4 Nov 5, 2015
linuxdaemon pushed a commit to linuxdaemon/CloudBot that referenced this pull request Nov 14, 2017
@edwardslabs
Merge pull request CloudBotIRC#208 from linuxdaemon/gonzobot+plugin-t…
5021c4d 
…asks

Shutdown all running hooks when a plugin is unloaded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Red-M @TheReverend403 @dmptrluke