Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable automatic spilling to disk by default #73422

Merged
merged 17 commits into from
Dec 27, 2024
Merged

Enable automatic spilling to disk by default #73422

merged 17 commits into from
Dec 27, 2024

Conversation

Michicosun
Copy link
Member

@Michicosun Michicosun commented Dec 17, 2024 •
edited
Loading

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Run only fuzzers related jobs (libFuzzer fuzzers, AST fuzzers, etc.)
  • Exclude: AST fuzzers
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Dec 17, 2024
@robot-ch-test-poll1
Copy link
Contributor

robot-ch-test-poll1 commented Dec 17, 2024 •
edited by robot-clickhouse
Loading

This is an automated comment for commit ad599f2 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc❌ failure
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@thevar1able thevar1able self-assigned this Dec 17, 2024
@thevar1able
Copy link
Member

Don't forget to update SettingsChangesHistory

@Michicosun
Copy link
Member Author

waiting #73728

@Michicosun
Copy link
Member Author

Stateless tests flaky check (asan) - Probably too many tests were run in parallel in flaky check. I think the changes do not affect the runs.

Integration tests (aarch64) [6/6] - Some problem with dns in tests No route to host - should not be related.

@Michicosun Michicosun added this pull request to the merge queue Dec 27, 2024
Merged via the queue into master with commit 0b3458d Dec 27, 2024
211 of 217 checks passed
@Michicosun Michicosun deleted the issues/69286/enable branch December 27, 2024 10:22
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Dec 27, 2024
baibaichen added a commit to Kyligence/gluten that referenced this pull request Dec 28, 2024
@baibaichen
Fix UT due to ClickHouse/ClickHouse#73422
1e5a6a7
baibaichen added a commit to apache/incubator-gluten that referenced this pull request Dec 28, 2024
@kyligence-git @baibaichen
[GLUTEN-1632][CH]Daily Update Clickhouse Version (20241228) (#8368)
49f6657 
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20241228)

* Fix UT due to ClickHouse/ClickHouse#73422

---------

Co-authored-by: kyligence-git <gluten@kyligence.io>
Co-authored-by: Chang Chen <baibaichen@gmail.com>
rschu1ze
rschu1ze reviewed Dec 30, 2024
View reviewed changes
src/Core/Settings.cpp
@@ -2391,7 +2391,7 @@ What to do when the limit is exceeded.
DECLARE(UInt64, max_bytes_before_external_group_by, 0, R"(
If memory usage during GROUP BY operation is exceeding this threshold in bytes, activate the 'external aggregation' mode (spill data to disk). Recommended value is half of the available system memory.
)", 0) \
DECLARE(Double, max_bytes_ratio_before_external_group_by, 0., R"(
DECLARE(Double, max_bytes_ratio_before_external_group_by, 0.5, R"(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Michicosun https://github.com/ClickHouse/ClickHouse/pull/71406/files#diff-bd80c4328eff8a0779b6f7227e8d6d699b1497088e5883becf218e21d955b3b1 stated that the internals are subject to change. Since the ratio setting is now the default, let's remove the note I referenced?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, totally forgot about those notes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#74000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rschu1ze rschu1ze rschu1ze left review comments

@thevar1able thevar1able thevar1able approved these changes

Assignees

@thevar1able thevar1able

Labels
pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Michicosun @robot-ch-test-poll1 @thevar1able @rschu1ze @robot-ch-test-poll2 @robot-ch-test-poll4