Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Skater profession into one with blades and another with a board #66813

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

KittyTac
Copy link
Contributor

Summary

Content "Split Skater profession into one with blades and another with a board"

Purpose of change

There was a skateboard vehicle added (#66596) and it felt weird to not have a profession that starts with it.

Describe the solution

Make a similar profession to Skater Person, but with sneakers instead of rollerblades + a folded skateboard. It has 2 vehicles, and both it and Skater person (Rollerblades) have 2 athletics now.

Describe alternatives you've considered

Leaving as is, adding a different flavor.

Testing

изображение
изображение

Additional context

skamtebord

Hopefully this gets someone to add a sprite for it...

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies labels Jul 11, 2023
data/json/professions.json Outdated Show resolved Hide resolved
data/json/professions.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Jul 11, 2023
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jul 11, 2023
@Maleclypse Maleclypse merged commit b1c3059 into CleverRaven:master Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants