Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Location Achievements #64712

Merged
merged 3 commits into from
Apr 1, 2023
Merged

Additional Location Achievements #64712

merged 3 commits into from
Apr 1, 2023

Conversation

RanikOrtega
Copy link
Contributor

@RanikOrtega RanikOrtega commented Mar 31, 2023

Summary

Content "Addition of Achievements for major locations"

Purpose of change

Create additional Achievements for a handful of Important locations. Hub 01 / Exodii Base / Church Retreat etc

Describe the solution

Took framework of Refugee center achievement and created additional versions for several other locations.

Describe alternatives you've considered

None.

Testing

Used Debug menu to teleport to Exodii base, Hub 01 and Church retreat. Confirmed achievement activation.

Additional context

@github-actions
Copy link
Contributor

You are creating a pull request with the master branch as the head branch. This is likely a mistake unless you really know what you are doing. You may read https://docs.github.com/en/get-started/quickstart/contributing-to-projects#creating-a-branch-to-work-on for a typical workflow of contributing to a project on GitHub.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Game: Achievements / Conducts / Scores Player goals and how they are tracked. labels Mar 31, 2023
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@Maleclypse
Copy link
Member

Do you mind adding a picture of one of the achievements happening? It's a good way to show it works.

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Mar 31, 2023
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 31, 2023
@GuardianDll
Copy link
Member

What about adding an achievement for portal dungeon?

@RanikOrtega
Copy link
Contributor Author

image

image

image

Do you mind adding a picture of one of the achievements happening? It's a good way to show it works.

What about adding an achievement for portal dungeon?

I plan on adding other location achievements but those were the quickest to test and confirm.

@bombasticSlacks bombasticSlacks merged commit 465fac4 into CleverRaven:master Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Game: Achievements / Conducts / Scores Player goals and how they are tracked. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants