Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docs based on #52023 and #51997 #52028

Conversation

ProfoundDarkness
Copy link
Contributor

@ProfoundDarkness ProfoundDarkness commented Oct 1, 2021

Summary

Build "Updated documentation to be in line with moving MXE gcc to version 11 + libbacktrace"

Purpose of change

I noticed a couple of PRs got merged today, #52023 and #51997.

Describe the solution

All modification of documentation only. Also only in relation to MXE (MingW).

  • instructions for downloading and installing libbacktrace.
  • Tweaked the gcc version for mxe to build.
  • Altered compiler supported (MingW) to target 11.2 instead of 9.3.
  • Removed the flag unsets for PCH and LIBBACKTRACE as new instructions support those flags being enabled when building C:DDA.
  • Added a hint to rebuild mxe if potential contributors had previously built MXE.

Describe alternatives you've considered

Done nothing...
Leave out the hint that people may need to clean and rebuild their MXE to get gcc11.

Testing

Rebuilt MXE with the changed line.
Tested out the download and extraction commands.
Built x64 windows C:DDA and ran it on windows, seemed to work fine.

Did NOT test 32 bit builds... I'm a bit constrained at the moment and I can't do both (within reason).

Additional context

I only just started reading about workflows yesterday so I may have misinterpreted what the two referenced PRs did and thus my instructions are incorrect. My impression of workflows is something like a hybrid of shell script and makefile directives.

Some side stuff that could be of note:

  • ncurses no longer builds for MXE, it was still building with MXE set to gcc5 and gcc9 but doesn't when set to gcc11. C:DDA documentation says (in remark) that ncurses for Windows being a non-starter, now looks even more correct.
  • LTO flag set still fails to build.

@anothersimulacrum anothersimulacrum added Code: Build Issues regarding different builds and build environments OS: Windows Issues related to Windows operating system labels Oct 1, 2021
@ProfoundDarkness ProfoundDarkness force-pushed the Branch_update_docs_mxe_build branch from 8998c36 to c9526e8 Compare October 1, 2021 21:14
@ProfoundDarkness
Copy link
Contributor Author

ProfoundDarkness commented Oct 1, 2021

OK, I think I've caught copy errors and tested to some degree of satisfaction so I'll open it up for review. I've also squashed the commits down, hopefully makes for an easier review.

@ProfoundDarkness ProfoundDarkness marked this pull request as ready for review October 1, 2021 21:35
@BrettDong
Copy link
Member

LTO flag set still fails to build.

Yeah I got internal compiler error during LTO linking stage.

Copy link
Member

@BrettDong BrettDong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BrettDong BrettDong added the <Documentation> Design documents, internal info, guides and help. label Oct 2, 2021
@kevingranade kevingranade merged commit 294e7c2 into CleverRaven:master Oct 2, 2021
@ProfoundDarkness ProfoundDarkness deleted the Branch_update_docs_mxe_build branch October 2, 2021 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code: Build Issues regarding different builds and build environments <Documentation> Design documents, internal info, guides and help. OS: Windows Issues related to Windows operating system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants