Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add build hash to nightly builds for version #951

Merged
merged 2 commits into from
Jan 2, 2023
Merged

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Jan 2, 2023

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

This adds the build hash to the btm -V output for nightly builds, making it easier to troubleshoot when someone might have obtained a nightly build, and what commit it corresponds to.

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Manually run nightly build workflows:

  • Nightly test one, should show the hash.
  • Nightly test two with hashing disabled via a typo to simulate a non-nightly build. This will fail because I'm lazy and want to check the versions in CI, but that causes issues for cross build targets.

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

@ClementTsang ClementTsang force-pushed the hash_nightly branch 2 times, most recently from b9a1ec7 to ae685d0 Compare January 2, 2023 10:29
@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2023

Codecov Report

Base: 20.69% // Head: 20.72% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (f7bca1b) compared to base (a56e7f6).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #951      +/-   ##
==========================================
+ Coverage   20.69%   20.72%   +0.02%     
==========================================
  Files          75       75              
  Lines       14622    14627       +5     
==========================================
+ Hits         3026     3031       +5     
  Misses      11596    11596              
Impacted Files Coverage Δ
src/clap.rs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ClementTsang ClementTsang force-pushed the hash_nightly branch 7 times, most recently from 05cfe66 to 6cce34e Compare January 2, 2023 19:51
@ClementTsang ClementTsang merged commit 7c53f08 into master Jan 2, 2023
@ClementTsang ClementTsang deleted the hash_nightly branch January 2, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants