Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: Make proc widget unit consistent with disk #443

Merged
merged 2 commits into from
Apr 4, 2021

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Apr 4, 2021

In particular, use non-binary prefixes for disk and memory usage in a process. Ideally everything is configurable by the user, but this is fine for now IMO until I can get around to doing in-app config.

Description

A description of the change and what it does. If relevant (such as any change that modifies the UI), please provide screenshots of the change:

Issue

If applicable, what issue does this address?

Closes: #

Type of change

Remove the irrelevant ones:

  • Other (something else - please specify) Just makes this consistent with disk widget.

Test methodology

If relevant, please state how this was tested:

Furthermore, please tick which platforms this change was tested on:

  • Windows
  • macOS
  • Linux

If relevant, all of these platforms should be tested.

Checklist

If relevant, ensure the following have been met:

  • Change has been tested to work, and does not cause new breakage unless intended
  • Code has been self-reviewed
  • Documentation has been added/updated if needed (README, help menu, etc.)
  • Passes CI pipeline (clippy check and cargo test check)
  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • No merge conflicts arise from the change

Other information

Provide any other relevant information to this change:

In particular, use non-binary prefixes for disk and memory usage in a
process.
@ClementTsang ClementTsang merged commit 476aaff into master Apr 4, 2021
@ClementTsang ClementTsang deleted the change_proc_read_mem_unit branch April 4, 2021 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant