Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colours if selected and F1-3 keys for search options #34

Merged
merged 3 commits into from
Feb 26, 2020

Conversation

ClementTsang
Copy link
Owner

Added different colours to search options if selected; added F1-3 keys as an alternative for searching. Both are available, but on macOS F1-3 will be suggested instead.

Description

A description of the change and what it does. If relevant, please provide screenshots of what results from the change:

Two main things:

  • Add colours if search options are toggled on (and no colour if off)

  • Add F1, F2, and F3 as case, whole word, and regex options as alternatives. Both the original bindings work if available, but on macOS, F1-F3 will be suggested rather than their Alt counterparts.

Finally a documentation fix in README and ? menu where Alt-W was labelled incorrectly.

Issue

If applicable, what issue does this address?

Issue: #29

Type of change

Remove the irrelevant one:

  • New feature (non-breaking change which adds functionality)

Test methodology

Please state how this was tested:

  • Tested on Arch Linux, Kitty Term, to ensure no previous functionality was lost. F1-F3 tested. Colours tested.

  • Tested on macOS to ensure the F1-F3 feature works and is displayed instead.

Checklist

Please ensure all are ticked (and actually done):

  • Code has been linted
  • Code has been self-reviewed
  • Code has been tested and no new breakage is introduced
  • Documentation has been added

Other information

Provide any other relevant information:

Added different colours to search options if selected; added F1-3 keys as an alternative for searching.  Both are available, but on macOS F1-3 will be suggested instead.
@ClementTsang ClementTsang linked an issue Feb 26, 2020 that may be closed by this pull request
@ClementTsang ClementTsang merged commit cdf464f into master Feb 26, 2020
@ClementTsang ClementTsang deleted the alternate_alt_macos branch February 26, 2020 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Give alternative keybinds for Alt-* for macOS users
1 participant