Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rewrite column algorithm #227

Merged
merged 12 commits into from
Sep 10, 2020
Merged

refactor: rewrite column algorithm #227

merged 12 commits into from
Sep 10, 2020

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Sep 8, 2020

Description

A description of the change and what it does. If relevant, please provide screenshots of what results from the change:

Update how we position and generate column widths to look less terrible... I think.

For example, left is old, right is new:
image

This also adds truncation w/ ellipsis to the columns!
image

And, for processes, the state will automatically shrink to a short form (just a character) if there isn't enough space:
image

Issue

If applicable, what issue does this address?

Closes: #225

Type of change

Remove the irrelevant ones:

  • Refactoring (some change that doesn't change functionality; if relevant state what was changed)

Test methodology

If required, please state how this was tested:

Furthermore, please tick which platforms this change was tested on:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, see if the following have been met:

  • Change has been tested to work
  • Areas your change affects have been linted using rustfmt
  • Code has been self-reviewed
  • Code has been tested and no new breakage is introduced unless intended
  • Passes CI tests
  • Documentation has been added/updated if needed (README, help menu, etc.)
  • No merge conflicts arise from the change

Other information

Provide any other relevant information:

@ClementTsang ClementTsang marked this pull request as ready for review September 10, 2020 01:26
@ClementTsang ClementTsang merged commit c58b2c2 into master Sep 10, 2020
@ClementTsang ClementTsang deleted the column_refactor branch September 10, 2020 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redo column width generation
1 participant