Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes count being sortable, but nothing occuring #224

Merged
merged 2 commits into from
Sep 6, 2020

Conversation

ClementTsang
Copy link
Owner

Description

A description of the change and what it does. If relevant, please provide screenshots of what results from the change:

Fixes sorting by count being available, but doing nothing. This fix makes it sortable.

Issue

If applicable, what issue does this address?

Closes: #

Type of change

Remove the irrelevant ones:

  • Bug fix (non-breaking change which fixes an issue)

Test methodology

If required, please state how this was tested:

Furthermore, please tick which platforms this change was tested on:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, see if the following have been met:

  • Change has been tested to work
  • Areas your change affects have been linted using rustfmt
  • Code has been self-reviewed
  • Code has been tested and no new breakage is introduced unless intended
  • Passes CI tests
  • Documentation has been added/updated if needed (README, help menu, etc.)
  • No merge conflicts arise from the change

Other information

Provide any other relevant information:

@ClementTsang ClementTsang added the bug Something isn't working the way that is expected. label Sep 6, 2020
@ClementTsang ClementTsang merged commit 0d8572c into master Sep 6, 2020
@ClementTsang ClementTsang deleted the fix_count_sort branch September 6, 2020 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working the way that is expected.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant