Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sorting by any column #183

Merged
merged 8 commits into from
Aug 16, 2020
Merged

Allow sorting by any column #183

merged 8 commits into from
Aug 16, 2020

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Aug 14, 2020

Description

A description of the change and what it does. If relevant, please provide screenshots of what results from the change:

This feature allows any column to be sortable.

This also adds:

  • Inverting sort for current column with I
  • Invoking a sort widget with s or F6. Close with same key or esc.

And:

  • A bugfix in regards the basic menu and battery widget
  • A lot of refactoring

Issue

If applicable, what issue does this address?

Closes: #178

Type of change

Remove the irrelevant ones:

  • Bug fix
  • New feature (non-breaking change which adds functionality)
  • Refactoring (some change that doesn't change functionality; if relevant state what was changed)

Test methodology

If required, please state how this was tested:

Furthermore, please tick which platforms this change was tested on:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, see if the following have been met:

  • Change has been tested to work
  • Areas your change affects have been linted using rustfmt
  • Code has been self-reviewed
  • Code has been tested and no new breakage is introduced unless intended
  • Passes CI tests
  • Documentation has been added/updated if needed (README, help menu, etc.)
  • No merge conflicts arise from the change

Other information

Provide any other relevant information:

This is not a complete feature, but this contains the basic parts for
it.

Features included so far:
- Inverting sort for current column with `I`
- Invoking a sort widget with `s` or `F6`.  Close with same key or esc.
- Custom sorting selection working w/ mouse and keyboard controls!

Things still left to be done:
- Basic mode is bugged
- No screen-adaptive scrolling done for the widget (hook up existing
  ones to it!)
- Documentation (`I`, `s/F6`)
@ClementTsang ClementTsang marked this pull request as ready for review August 15, 2020 20:54
@ClementTsang ClementTsang merged commit f3897f0 into master Aug 16, 2020
@ClementTsang ClementTsang deleted the sort_by_io branch August 16, 2020 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make process I/O sortable
1 participant