Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: display arc max size in arc usage instead of system memory #1264

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

zebp
Copy link
Contributor

@zebp zebp commented Jul 23, 2023

Description

Previously the ARC usage showed it having a maximum size of the amount of ram in the system regardless of what zfs_arc_max was set to.

image

Testing

Changes were tested by changing the arc max size and ensuring the value was reflected in bottom.

  • Windows
  • macOS
  • Linux
  • FreeBSD

Checklist

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

@codecov
Copy link

codecov bot commented Jul 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (dbf0545) 31.66% compared to head (cf95cdb) 31.66%.

❗ Current head cf95cdb differs from pull request most recent head 506ebbb. Consider uploading reports for the commit 506ebbb to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1264   +/-   ##
=======================================
  Coverage   31.66%   31.66%           
=======================================
  Files          98       98           
  Lines       16669    16669           
=======================================
  Hits         5279     5279           
  Misses      11390    11390           
Flag Coverage Δ
macos-12 33.42% <0.00%> (ø)
ubuntu-latest 33.25% <0.00%> (ø)
windows-2019 33.65% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/app/data_harvester/memory/arc.rs 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementTsang ClementTsang self-assigned this Jul 24, 2023
@zebp zebp force-pushed the zeb/arc-display-max-size branch from cf95cdb to 506ebbb Compare July 24, 2023 21:52
Copy link
Owner

@ClementTsang ClementTsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thanks for catching this. I'll merge in a bit, I can also try and test on FreeBSD.

@ClementTsang ClementTsang merged commit a336c64 into ClementTsang:master Jul 27, 2023
@ClementTsang
Copy link
Owner

@all-contributors please add @zebp for code.

@allcontributors
Copy link
Contributor

@ClementTsang

I've put up a pull request to add @zebp! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants