other: support hw.temperature-based temps on FreeBSD #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 21.31% // Head: 21.55% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1024 +/- ##
==========================================
+ Coverage 21.31% 21.55% +0.23%
==========================================
Files 75 75
Lines 14754 14590 -164
==========================================
Hits 3145 3145
+ Misses 11609 11445 -164
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ClementTsang
force-pushed
the
support_freebsd_rockpro64_temps
branch
from
209436b to
0aef56d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:
Add simple support for FreeBSD-based systems that may get temperatures using sysctl and
hw.temperature.Issue
If applicable, what issue does this address?
Closes: #797
Testing
If relevant, please state how this was tested. All changes must be tested to work:
If this is a code change, please also indicate which platforms were tested:
I tested whether the code works for some sysctl - I tried it with
dev.cpuon my FreeBSD box, and it works. I did not test it forhw.temperature, as that does nothing for my x86-64-based FreeBSD machine.Checklist
If relevant, ensure the following have been met:
cargo fmt)README.md, help menu, doc pages, etc.)