Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Debian] Question about dependencies #787

Closed
werdahias opened this issue Aug 19, 2022 · 10 comments · Fixed by #1064
Closed

[Debian] Question about dependencies #787

werdahias opened this issue Aug 19, 2022 · 10 comments · Fixed by #1064
Labels
packaging For issues regarding packaging and distribution.

Comments

@werdahias
Copy link

Hi, I'm in the process of packaging all the dependencies for bottom so we can get an official debian package. On crates.io it states battery as dependency. The current github includes nvml-wrapper and starship-battery instead. Will these be included in the next release (instead of battery)?

@werdahias werdahias added the packaging For issues regarding packaging and distribution. label Aug 19, 2022
@ClementTsang
Copy link
Owner

@werdahias Yes, those would be included. starship-battery is the succeeding fork I'm using to somewhat abandoned battery crate (#724), and nvml-wrapper is used for Nvidia card details (#676).

On that note, I'm probably going to try and release a new stable version soon since it's been a while since the last release.

@werdahias
Copy link
Author

Great, thanks. For debian, the only missing chunk is heim which will be a bit of work.

@ClementTsang
Copy link
Owner

If it's any consolation, I'm planning on eventually removing the heim dependency since it's not really maintained anymore.

@werdahias
Copy link
Author

Will that make in in the new release? That would save me a lot of work

@ClementTsang
Copy link
Owner

ClementTsang commented Aug 19, 2022

Might take a look this weekend and get back to you. If it isn't too bad (I don't think it would be...) then maybe?

Of course, no promises...

@werdahias
Copy link
Author

Yeah no worries, take you time

@werdahias
Copy link
Author

starship-battery is in debian, so the only thing "missing" would be heim

@werdahias
Copy link
Author

all dependencies are in debian except cargo-husky and heim. I guess I can patch out cargo-husky or package it.

@ClementTsang
Copy link
Owner

Yep, husky can be patched out if that's easier (it's mostly just for dev purposes), and I'm working on removing heim.

@ClementTsang
Copy link
Owner

Closing this as heim is now removed; from 0.9.0 onward I think the only problematic thing is husky, which shouldn't be too hard hopefully to patch out if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging For issues regarding packaging and distribution.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants