[Feature] added ability to rotate ChartLimitLine label #5085

berbaspin · 2023-07-19T06:16:54Z

Goals ⚽

Added labelRotationAngle to ChartLimitLine

Testing Details 🔍

Tested on line chart and horizontal bar chart both XAxis and YAxis and all four label positions.

berbaspin · 2023-07-21T04:46:44Z

@pmairoldi, @FelixHerrmann, @liuxuan30, could I get a review of this PR?

liuxuan30 · 2023-07-24T01:42:18Z

@berbaspin could you share a screenshot, what this can achieve? how 'configurable' the angle can be? Have you tested it thoroughfuly?

btw if the angle is fully configurable, I would hope we could add a UT for this feature? like define 0/30/45/60/90/180 degree rotation for one chart(e.g. line chart) so we make sure this is robust.

berbaspin · 2023-07-24T08:08:51Z

@liuxuan30 previously, we had a functionality that allowed us to rotate the xAxis label. I added the same functionality for Limit Line. As example: 90 degrees.

But also we can use non-standard angle. Examples: 17 and 285 degrees

We can rotate limit line without xAxis label rotation.

I tested this on Bar Chart, Line Chart and Horizontal Chart. For all types of label position (leftTop, leftBottom, rightTop, rightBottom). Examples:

Yeah, I also can write a UT for this feature. Will it be enough to write 3 tests with different angles?

   func testLimitLineLabelRotatedBy90() {
        let limitline = ChartLimitLine(limit: 50, label: "Limit Line")
        limitline.labelPosition = .rightTop
        limitline.labelRotationAngle = 90
        chart.leftAxis.addLimitLine(limitline)
        assertChartSnapshot(matching: chart)
    }

    func testLimitLineLabelRotatedBy30() {
        let limitline = ChartLimitLine(limit: 50, label: "Limit Line")
        limitline.labelPosition = .leftBottom
        limitline.labelRotationAngle = 30
        chart.leftAxis.addLimitLine(limitline)
        assertChartSnapshot(matching: chart)
    }

    func testLimitLineLabelDefaultRotation() {
        let limitline = ChartLimitLine(limit: 50, label: "Limit Line")
        limitline.labelPosition = .rightBottom
        chart.leftAxis.addLimitLine(limitline)
        assertChartSnapshot(matching: chart)
    }

liuxuan30 · 2023-07-25T11:21:54Z

previously, we had a functionality that allowed us to rotate the xAxis label

So we are just adding limitline label rotation, no xAxis label rotation, right?

What's the center of the rotated limitline label? e.g. where's the center of the limitline label in different angel? Is the center same as non rotated position?

liuxuan30 · 2023-07-25T11:22:34Z

Yeah, I also can write a UT for this feature. Will it be enough to write 3 tests with different angles?

Yeah, I suggest we add 30/45/60/90/120/180 to cover the typical angles

berbaspin · 2023-07-26T06:06:52Z

So we are just adding limitline label rotation, no xAxis label rotation, right?

@liuxuan30, yes. My pull request contains only limitline label rotation.
I used rotation anchor - CGPoint(x: 0.0, y: 0.0). It allows to be accurate in calculations and not cross the limit line with the label regardless of the angle of rotation. Examples are below. I also compared the limit line label rotation with xAxis labels rotations and they looks the same.

Example of rotation by 3 angles (0, 45, 90) of horizontal limit line.

Example of rotation by 3 angles (45, 90, 180) of vertical limit line.

Example of rotation by 120 degrees with xAxis.

berbaspin · 2023-07-26T06:16:37Z

Yeah, I suggest we add 30/45/60/90/120/180 to cover the typical angles

Are the tests above correct? I can append 45/60/120/180 to them and update current pull request.

liuxuan30 · 2023-07-28T01:33:53Z

if this is the case, I'm kind of ok.

@pmairoldi @jjatie any comments? I think we could get this merged.

pmairoldi · 2023-07-28T02:47:13Z

Seems fine to me.

liuxuan30 · 2023-07-28T08:48:24Z

ok then. @berbaspin please help add the tests, and we will take a look and move forward, thank you for your efforts!

berbaspin · 2023-07-28T09:30:53Z

@liuxuan30, cool! Should I create new commit with tests or will you add them by yourself?
Below tests with different label positions and angles (LineChartTests).

func testLimitLineLabelRotatedBy180() {
        addLimitLineWithRotatedAngle(labelPosition: .rightBottom, labelRotationAngle: 180)
        assertChartSnapshot(matching: chart)
    }

    func testLimitLineLabelRotatedBy120() {
        addLimitLineWithRotatedAngle(labelPosition: .rightTop, labelRotationAngle: 120)
        assertChartSnapshot(matching: chart)
    }

    func testLimitLineLabelRotatedBy90() {
        addLimitLineWithRotatedAngle(labelPosition: .leftTop, labelRotationAngle: 90)
        assertChartSnapshot(matching: chart)
    }

    func testLimitLineLabelRotatedBy45() {
        addLimitLineWithRotatedAngle(labelPosition: .leftBottom, labelRotationAngle: 45)
        assertChartSnapshot(matching: chart)
    }

    func testLimitLineLabelRotatedBy30() {
        addLimitLineWithRotatedAngle(labelPosition: .leftBottom, labelRotationAngle: 30)
        assertChartSnapshot(matching: chart)
    }

    func testLimitLineLabelDefaultRotation() {
        addLimitLineWithRotatedAngle(labelPosition: .rightTop, labelRotationAngle: 0)
        assertChartSnapshot(matching: chart)
    }

    private func addLimitLineWithRotatedAngle(labelPosition: ChartLimitLine.LabelPosition, labelRotationAngle: CGFloat) {
        let limitline = ChartLimitLine(limit: 50, label: "Limit Line")
        limitline.labelPosition = labelPosition
        limitline.labelRotationAngle = labelRotationAngle
        chart.leftAxis.addLimitLine(limitline)
    }

berbaspin · 2023-08-01T05:01:30Z

@liuxuan30, are there any improvements I should make?

Source/Charts/Renderers/XAxisRenderer.swift

Source/Charts/Renderers/YAxisRendererHorizontalBarChart.swift

liuxuan30 · 2023-08-16T02:01:15Z

Sorry for the late response, took a week off work. I have completed the review, left a few comments.

Meanwhile, I have triggered the work flow so we can check the CI result later

liuxuan30 · 2023-08-16T02:03:57Z

regarding Swift / Build framework (OS=16.1,name=Apple TV 4K (3rd generation), build test)
seems you forgot to generate test images for apple TV;

labelLineRotated_Width/Height got the same position

berbaspin · 2023-08-16T06:34:46Z

@liuxuan30, I added two commits:

fixed the code style
labelLineRotated_Width/Height got the same position
generated test images for apple TV

please remind me why we can abandon align here?

I quickly looked at align, it is often used here:

let drawPoint = getDrawPoint(text: text, point: point, align: align, attributes: attributes)

We can abandon align, because it was used only for calculating the position of the label. But I used a different methodology.

In method, that was used before, the anchor was CGPoint(x: 0.5, y: 0.5) and TextAlignment (.left or .right). It works fine with non rotated labels. That's why I decided to сhange label x position by calculating labelLineRotatedWidth and set anchor to CGPoint(x: 0.0, y: 0.0).
I think that for HorizontalBarChartView is used similar calculations for xAxis label:

let xlabelwidth = xAxis.labelRotatedWidth
        
        if xAxis.isEnabled
        {
            // offsets for x-labels
            if xAxis.labelPosition == .bottom
            {
                offsetLeft += xlabelwidth
            }
            else if xAxis.labelPosition == .top
            {
                offsetRight += xlabelwidth
            }
            else if xAxis.labelPosition == .bothSided
            {
                offsetLeft += xlabelwidth
                offsetRight += xlabelwidth
            }
        }

liuxuan30 · 2023-08-18T10:17:26Z

thanks! let's wait for the CI results

liuxuan30 · 2023-08-18T10:19:18Z

@liuxuan30, I added two commits:

fixed the code style

labelLineRotated_Width/Height got the same position

generated test images for apple TV

please remind me why we can abandon align here?
I quickly looked at align, it is often used here:
let drawPoint = getDrawPoint(text: text, point: point, align: align, attributes: attributes)

We can abandon align, because it was used only for calculating the position of the label. But I used a different methodology.

In method, that was used before, the anchor was CGPoint(x: 0.5, y: 0.5) and TextAlignment (.left or .right). It works fine with non rotated labels. That's why I decided to сhange label x position by calculating labelLineRotatedWidth and set anchor to CGPoint(x: 0.0, y: 0.0). I think that for HorizontalBarChartView is used similar calculations for xAxis label:
let xlabelwidth = xAxis.labelRotatedWidth
        
        if xAxis.isEnabled
        {
            // offsets for x-labels
            if xAxis.labelPosition == .bottom
            {
                offsetLeft += xlabelwidth
            }
            else if xAxis.labelPosition == .top
            {
                offsetRight += xlabelwidth
            }
            else if xAxis.labelPosition == .bothSided
            {
                offsetLeft += xlabelwidth
                offsetRight += xlabelwidth
            }
        }

I'm kind of concerned that, it used to support align.center, but when we removed this, how do we implement .center behavior? If a current user uses .center, then after the new update, how to do it?

berbaspin · 2023-08-19T11:04:46Z

@liuxuan30, sorry, but I can't find the place, where we can change the alignment of the limitline's label. Neither ChartLimitLine, nor ComponentBase has such property. We only have the ability to change the position of the ChartLimitLine Label. We have enum:

public enum LabelPosition: Int
    {
        case leftTop
        case leftBottom
        case rightTop
        case rightBottom
    }

There are no cases centerTop or centerBottom.

This function also doesn't have the alignment parameter.
open override func renderLimitLines(context: CGContext)

But there is an initialization of align and a value assignment depending of LabelPosition. (I found only here)

renderLimitLines calls another function drawText. And here we have two types of it (they both available in current version of DGCharts and I didn't make any changes to them):

public func drawText(_ text: String, at point: CGPoint, align: TextAlignment, anchor: CGPoint = CGPoint(x: 0.5, y: 0.5), angleRadians: CGFloat = 0.0, attributes: [NSAttributedString.Key : Any]?)
public func drawText(_ text: String, at point: CGPoint, anchor: CGPoint = CGPoint(x: 0.5, y: 0.5), angleRadians: CGFloat, attributes: [NSAttributedString.Key : Any]?)

The first function was used with ChartLimitLine label in current version of DGCharts. But I replaced it with the second one.
If we check the first function, we will see, that it calls the second one, if rotation angle is not 0.0.

If user overrides one of this function open override func renderLimitLines(context: CGContext) or public func drawText, my changes, that I offer in this pull request, will not take an effect on them, because the user has his own implementation.

P.S. Just for test. I took the current of DGCharts and tried to change align for leftAxis limit line label from .left to .center in open override func renderLimitLines(context: CGContext). It didn't fit in the center.

berbaspin · 2023-08-19T11:17:59Z

Previously I added generated images for Model: Apple TV 4K (3rd generation). tvOS 16.1 (20K67).
And CI failed again. I think it happens, because I created images only for AppleSilicon (both iOS and tvOS).

✗ testLimitLineLabelDefaultRotation, failed - No reference was found on disk. Automatically recorded snapshot: …
✗ testLimitLineLabelRotatedBy120, failed - No reference was found on disk. Automatically recorded snapshot: …
✗ testLimitLineLabelRotatedBy180, failed - No reference was found on disk. Automatically recorded snapshot: …
✗ testLimitLineLabelRotatedBy30, failed - No reference was found on disk. Automatically recorded snapshot: …
✗ testLimitLineLabelRotatedBy45, failed - No reference was found on disk. Automatically recorded snapshot: …
✗ testLimitLineLabelRotatedBy90, failed - No reference was found on disk. Automatically recorded snapshot:

Can you create them for x86_64? Using Rosetta I got an error:

debugserver is x86_64 binary running in translation, attached failed.

liuxuan30 · 2023-08-21T01:34:59Z

Can you create them for x86_64? Using Rosetta I got an error:

I can. I will update today or tomorrow.

Let's check if iOS CI works, it was canceld that I don't know how.

@berbaspin please add me with write acess to your Charts fork repo

liuxuan30 · 2023-08-21T01:58:35Z

@liuxuan30, sorry, but I can't find the place, where we can change the alignment of the limitline's label. Neither ChartLimitLine, nor ComponentBase has such property. We only have the ability to change the position of the ChartLimitLine Label. We have enum:
public enum LabelPosition: Int
    {
        case leftTop
        case leftBottom
        case rightTop
        case rightBottom
    }
There are no cases centerTop or centerBottom.

This function also doesn't have the alignment parameter. open override func renderLimitLines(context: CGContext)

But there is an initialization of align and a value assignment depending of LabelPosition. (I found only here)

renderLimitLines calls another function drawText. And here we have two types of it (they both available in current version of DGCharts and I didn't make any changes to them):

public func drawText(_ text: String, at point: CGPoint, align: TextAlignment, anchor: CGPoint = CGPoint(x: 0.5, y: 0.5), angleRadians: CGFloat = 0.0, attributes: [NSAttributedString.Key : Any]?)

public func drawText(_ text: String, at point: CGPoint, anchor: CGPoint = CGPoint(x: 0.5, y: 0.5), angleRadians: CGFloat, attributes: [NSAttributedString.Key : Any]?)

The first function was used with ChartLimitLine label in current version of DGCharts. But I replaced it with the second one. If we check the first function, we will see, that it calls the second one, if rotation angle is not 0.0.

If user overrides one of this function open override func renderLimitLines(context: CGContext) or public func drawText, my changes, that I offer in this pull request, will not take an effect on them, because the user has his own implementation.

P.S. Just for test. I took the current of DGCharts and tried to change align for leftAxis limit line label from .left to .center in open override func renderLimitLines(context: CGContext). It didn't fit in the center.

My mistake. My memory with Charts is rusty. You are right that this is the entry for drawText, not the opposite. I was thinking you are modifying drawText(), but actually it's renderLimitLines. So should be fine.

Let's fix the CI issues and get it merged

berbaspin · 2023-08-21T03:53:57Z

@berbaspin please add me with write acess to your Charts fork repo

@liuxuan30, I sent the invite

liuxuan30 · 2023-08-22T02:25:46Z

it's weird that the iOS CI keeps failing:

2023-08-22T01:32:35.7435390Z ▸ Touching DGChartsTests.xctest (in target 'DGChartsTests' from project 'Charts')
2023-08-22T01:34:35.7255440Z ##[debug]Re-evaluate condition on job cancellation for step: 'Build framework - OS=16.2,name=iPhone 14 Pro'.
2023-08-22T01:34:48.3605590Z ##[error]The operation was canceled.
2023-08-22T01:34:48.3620880Z ##[debug]System.OperationCanceledException: The operation was canceled.
2023-08-22T01:34:48.3621590Z ##[debug]   at System.Threading.CancellationToken.ThrowOperationCanceledException()
2023-08-22T01:34:48.3622510Z ##[debug]   at GitHub.Runner.Sdk.ProcessInvoker.ExecuteAsync(String workingDirectory, String fileName, String arguments, IDictionary`2 environment, Boolean requireExitCodeZero, Encoding outputEncoding, Boolean killProcessOnCancel, Channel`1 redirectStandardIn, Boolean inheritConsoleHandler, Boolean keepStandardInOpen, Boolean highPriorityProcess, CancellationToken cancellationToken)
2023-08-22T01:34:48.3623790Z ##[debug]   at GitHub.Runner.Common.ProcessInvokerWrapper.ExecuteAsync(String workingDirectory, String fileName, String arguments, IDictionary`2 environment, Boolean requireExitCodeZero, Encoding outputEncoding, Boolean killProcessOnCancel, Channel`1 redirectStandardIn, Boolean inheritConsoleHandler, Boolean keepStandardInOpen, Boolean highPriorityProcess, CancellationToken cancellationToken)
2023-08-22T01:34:48.3625040Z ##[debug]   at GitHub.Runner.Worker.Handlers.DefaultStepHost.ExecuteAsync(IExecutionContext context, String workingDirectory, String fileName, String arguments, IDictionary`2 environment, Boolean requireExitCodeZero, Encoding outputEncoding, Boolean killProcessOnCancel, Boolean inheritConsoleHandler, String standardInInput, CancellationToken cancellationToken)
2023-08-22T01:34:48.3626040Z ##[debug]   at GitHub.Runner.Worker.Handlers.ScriptHandler.RunAsync(ActionRunStage stage)
2023-08-22T01:34:48.3626470Z ##[debug]   at GitHub.Runner.Worker.ActionRunner.RunAsync()
2023-08-22T01:34:48.3626950Z ##[debug]   at GitHub.Runner.Worker.StepsRunner.RunStepAsync(IStep step, CancellationToken jobCancellationToken)

I have triggered a master branch CI to see what's going on

it's strange that master passed CI easily. Not sure why this PR always has canceled. Need investigate further.

liuxuan30 · 2023-08-22T02:41:25Z

it's weird that the iOS CI keeps failing:

2023-08-22T01:32:35.7435390Z ▸ Touching DGChartsTests.xctest (in target 'DGChartsTests' from project 'Charts')
2023-08-22T01:34:35.7255440Z ##[debug]Re-evaluate condition on job cancellation for step: 'Build framework - OS=16.2,name=iPhone 14 Pro'.
2023-08-22T01:34:48.3605590Z ##[error]The operation was canceled.
2023-08-22T01:34:48.3620880Z ##[debug]System.OperationCanceledException: The operation was canceled.
2023-08-22T01:34:48.3621590Z ##[debug]   at System.Threading.CancellationToken.ThrowOperationCanceledException()
2023-08-22T01:34:48.3622510Z ##[debug]   at GitHub.Runner.Sdk.ProcessInvoker.ExecuteAsync(String workingDirectory, String fileName, String arguments, IDictionary`2 environment, Boolean requireExitCodeZero, Encoding outputEncoding, Boolean killProcessOnCancel, Channel`1 redirectStandardIn, Boolean inheritConsoleHandler, Boolean keepStandardInOpen, Boolean highPriorityProcess, CancellationToken cancellationToken)
2023-08-22T01:34:48.3623790Z ##[debug]   at GitHub.Runner.Common.ProcessInvokerWrapper.ExecuteAsync(String workingDirectory, String fileName, String arguments, IDictionary`2 environment, Boolean requireExitCodeZero, Encoding outputEncoding, Boolean killProcessOnCancel, Channel`1 redirectStandardIn, Boolean inheritConsoleHandler, Boolean keepStandardInOpen, Boolean highPriorityProcess, CancellationToken cancellationToken)
2023-08-22T01:34:48.3625040Z ##[debug]   at GitHub.Runner.Worker.Handlers.DefaultStepHost.ExecuteAsync(IExecutionContext context, String workingDirectory, String fileName, String arguments, IDictionary`2 environment, Boolean requireExitCodeZero, Encoding outputEncoding, Boolean killProcessOnCancel, Boolean inheritConsoleHandler, String standardInInput, CancellationToken cancellationToken)
2023-08-22T01:34:48.3626040Z ##[debug]   at GitHub.Runner.Worker.Handlers.ScriptHandler.RunAsync(ActionRunStage stage)
2023-08-22T01:34:48.3626470Z ##[debug]   at GitHub.Runner.Worker.ActionRunner.RunAsync()
2023-08-22T01:34:48.3626950Z ##[debug]   at GitHub.Runner.Worker.StepsRunner.RunStepAsync(IStep step, CancellationToken jobCancellationToken)

I have triggered a master branch CI to see what's going on

it's strange that master passed CI easily. Not sure why this PR always has canceled. Need investigate further.

I trigged a test CI https://github.com/danielgindi/Charts/actions/runs/5933792579, it seems after correctly generating snapshots for the specific arch, it can now pass. the cancelled failures look like due to arch issue.
@berbaspin you can merge my PR in your repo and try again.

add tvOS and iOS snapshots on x64 arch

berbaspin · 2023-08-22T03:03:11Z

@liuxuan30, thank you! I merged your pull request

liuxuan30 · 2023-08-22T03:17:25Z

All green and merged. Thank you!

* gindi-master: (55 commits) [Feature] added ability to rotate ChartLimitLine label (ChartsOrg#5085) update readme fix podspec update ci update readme versions fix build issue remove swift-algorithms package in favor of manully importing needed functions fix ChartsOrg#5033: always run snapshot tests in light mode update tvos undo framework bump bump min version to 13 for ios project Bump actions/checkout to v3 Fix Xcode 14.3 import warnings add discardable results to operations that do not require result update readme to change name update workflow to run on release branches Change library name from Charts to DGCharts Unnecessary space Removal and Semicolons are removed Update README.md Turn on the BUILD_LIBRARY_FOR_DISTRIBUTION flag ...

* added labelRotationAngle to ChartLimitLine * added limit line label rotation tests * fixed the code style labelLineRotated_Width/Height got the same position * generated test images for apple TV * add snapshots on x64 arch for tvOS and iOS --------- Co-authored-by: Xuan <liuxuan30@noreply.github.com>

added labelRotationAngle to ChartLimitLine

bd4254e

added limit line label rotation tests

cd9f1f1

liuxuan30 requested changes Aug 16, 2023

View reviewed changes

Source/Charts/Renderers/XAxisRenderer.swift Outdated Show resolved Hide resolved

Source/Charts/Renderers/XAxisRenderer.swift Show resolved Hide resolved

Source/Charts/Renderers/YAxisRendererHorizontalBarChart.swift Outdated Show resolved Hide resolved

berbaspin added 2 commits August 16, 2023 11:20

fixed the code style

a062082

labelLineRotated_Width/Height got the same position

generated test images for apple TV

1c87921

berbaspin requested a review from liuxuan30 August 18, 2023 04:40

add snapshots on x64 arch for tvOS and iOS

8688db3

Merge pull request #1 from berbaspin/tests

5d6d2ac

add tvOS and iOS snapshots on x64 arch

liuxuan30 approved these changes Aug 22, 2023

View reviewed changes

liuxuan30 merged commit e516b04 into ChartsOrg:master Aug 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature] added ability to rotate ChartLimitLine label #5085

[Feature] added ability to rotate ChartLimitLine label #5085

berbaspin commented Jul 19, 2023

berbaspin commented Jul 21, 2023

liuxuan30 commented Jul 24, 2023

berbaspin commented Jul 24, 2023 •

edited

Loading

liuxuan30 commented Jul 25, 2023 •

edited

Loading

liuxuan30 commented Jul 25, 2023 •

edited

Loading

berbaspin commented Jul 26, 2023

berbaspin commented Jul 26, 2023

liuxuan30 commented Jul 28, 2023

pmairoldi commented Jul 28, 2023

liuxuan30 commented Jul 28, 2023

berbaspin commented Jul 28, 2023 •

edited

Loading

berbaspin commented Aug 1, 2023

liuxuan30 commented Aug 16, 2023 •

edited

Loading

liuxuan30 commented Aug 16, 2023

berbaspin commented Aug 16, 2023

liuxuan30 commented Aug 18, 2023

liuxuan30 commented Aug 18, 2023 •

edited

Loading

berbaspin commented Aug 19, 2023

berbaspin commented Aug 19, 2023 •

edited

Loading

liuxuan30 commented Aug 21, 2023 •

edited

Loading

liuxuan30 commented Aug 21, 2023

berbaspin commented Aug 21, 2023

liuxuan30 commented Aug 22, 2023

liuxuan30 commented Aug 22, 2023

berbaspin commented Aug 22, 2023

liuxuan30 commented Aug 22, 2023

[Feature] added ability to rotate ChartLimitLine label #5085

[Feature] added ability to rotate ChartLimitLine label #5085

Conversation

berbaspin commented Jul 19, 2023

Goals ⚽

Testing Details 🔍

berbaspin commented Jul 21, 2023

liuxuan30 commented Jul 24, 2023

berbaspin commented Jul 24, 2023 • edited Loading

liuxuan30 commented Jul 25, 2023 • edited Loading

liuxuan30 commented Jul 25, 2023 • edited Loading

berbaspin commented Jul 26, 2023

berbaspin commented Jul 26, 2023

liuxuan30 commented Jul 28, 2023

pmairoldi commented Jul 28, 2023

liuxuan30 commented Jul 28, 2023

berbaspin commented Jul 28, 2023 • edited Loading

berbaspin commented Aug 1, 2023

liuxuan30 commented Aug 16, 2023 • edited Loading

liuxuan30 commented Aug 16, 2023

berbaspin commented Aug 16, 2023

liuxuan30 commented Aug 18, 2023

liuxuan30 commented Aug 18, 2023 • edited Loading

berbaspin commented Aug 19, 2023

berbaspin commented Aug 19, 2023 • edited Loading

liuxuan30 commented Aug 21, 2023 • edited Loading

liuxuan30 commented Aug 21, 2023

berbaspin commented Aug 21, 2023

liuxuan30 commented Aug 22, 2023

liuxuan30 commented Aug 22, 2023

berbaspin commented Aug 22, 2023

liuxuan30 commented Aug 22, 2023

berbaspin commented Jul 24, 2023 •

edited

Loading

liuxuan30 commented Jul 25, 2023 •

edited

Loading

liuxuan30 commented Jul 25, 2023 •

edited

Loading

berbaspin commented Jul 28, 2023 •

edited

Loading

liuxuan30 commented Aug 16, 2023 •

edited

Loading

liuxuan30 commented Aug 18, 2023 •

edited

Loading

berbaspin commented Aug 19, 2023 •

edited

Loading

liuxuan30 commented Aug 21, 2023 •

edited

Loading