[ENG-5879] Hide Categories Section for Draft Registrations #2360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uditijmehta
force-pushed
the
eng-5879-hide-categories
branch
from
337a530 to
2376b42
Compare
uditijmehta
force-pushed
the
eng-5879-hide-categories
branch
from
2376b42 to
b166dc6
Compare
Pull Request Test Coverage Report for Build 11447201243Details
💛 - Coveralls |
brianjgeiger
requested changes
Oct 21, 2024
Comment on lines
83
to
85
| {{#if @node.category}} | ||
| {{node-card/node-icon category=@node.category}} | ||
| {{/if}} |
There was a problem hiding this comment.
This doesn't look right. Don't we want to hide the category always for registrations, not just when there's no category set?
uditijmehta
force-pushed
the
eng-5879-hide-categories
branch
from
a43bf82 to
a0b202a
Compare
| @@ -80,7 +80,6 @@ | |||
| {{/if}} | |||
| {{/if}} | |||
|
|
|||
| {{node-card/node-icon category=@node.category}} | |||
There was a problem hiding this comment.
This will remove it from regular nodes whiiiiich we may not be using anymore but I can't recall for sure. Maybe check @node.is_registration or similar and hide it if it's a registration.
uditijmehta
force-pushed
the
eng-5879-hide-categories
branch
from
a0b202a to
da8f229
Compare
brianjgeiger
approved these changes
Oct 21, 2024
cslzchen
added a commit
that referenced
this pull request
Oct 30, 2024
[ENG-5879] Hide Categories Section for Draft Registrations #2360
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Hide Categories Section for Draft Registrations
Summary of Changes