Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update namesandtypes.py #128

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Update namesandtypes.py #128

merged 1 commit into from
Dec 13, 2022

Conversation

Mas515
Copy link
Contributor

@Mas515 Mas515 commented Nov 14, 2022

Hi I was trying to measure Object Intensity in CP 4.2.4 and I was getting a dimension error (my y dimension had disappeared). I did not get this error in CP 4.2.1. I had imported the object in as object in the names and type module. My data is 3D. If I recreated the segmentation from the raw data the error did not appear + there is no differences in the measure Object Intensity of CP4.2.4 and CP4.2.1 so it looks like the error comes from the names and type module. Changing that line allows my pipeline to run.

Hi I was trying to measure Object Intensity in CP 4.2.4 and I was getting a dimension error (my y dimension had disappeared). I did not get this error in CP 4.2.1. I had imported the object in as object in the names and type module. My data is 3D. If I recreated the segmentation from the raw data the error did not appear + there is no differences in the measure  Object Intensity of CP4.2.4 and CP4.2.1 so it looks like the error comes from the names and type module. Changing that line allows my pipeline to run.
@bethac07
Copy link
Member

bethac07 commented Nov 15, 2022

Thanks for this @Mas515 ! Before we pull, two things should happen

  1. We need to check if CellProfiler's tests pass - that is automatically running now - yup, they did
  2. We (which could be you or someone on our team) should one or more tests to check for this particular bug.

@bethac07 bethac07 linked an issue Nov 15, 2022 that may be closed by this pull request
@rsenft1
Copy link
Collaborator

rsenft1 commented Nov 17, 2022

Thanks for identifying this @Mas515 ! I added a new test #129 that will catch this type of error in the future (it explicitly checks for dimension changes or object loss when loading 3D objects) so I think we should good to go here.

@bethac07 bethac07 merged commit 0fb84e8 into CellProfiler:master Dec 13, 2022
@bethac07 bethac07 mentioned this pull request Dec 13, 2022
gnodar01 pushed a commit to gnodar01/cp_full that referenced this pull request Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error loading 3D label matrices
3 participants