Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Crawling Sensation + related tweaks #4744

Merged
merged 10 commits into from
Feb 27, 2024
Merged

Fix Crawling Sensation + related tweaks #4744

merged 10 commits into from
Feb 27, 2024

Conversation

tool4ever
Copy link
Contributor

Unlike its newer cousin (Crawling Infestation) the trigger on Crawling Sensation should see the past with "for the first time" - so perhaps might never be able to trigger on the turn it ETB.

@tool4ever tool4ever added Game Mechanics Card Patch Fixing bugged card scripts Rules compliance Bringing the engine or cards closer to CR labels Feb 26, 2024
@tool4ever tool4ever marked this pull request as draft February 26, 2024 09:15
Hanmac
Hanmac previously approved these changes Feb 26, 2024
View reviewed changes
@Hanmac
Copy link
Contributor

Hanmac commented Feb 27, 2024

@tool4ever should we look at this again? especially the SpellAbility one?

forge/forge-game/src/main/java/forge/game/ability/AbilityKey.java

Lines 208 to 217 in da91107

public static void addCardZoneTableParams(Map<AbilityKey, Object> map, CardZoneTable table) {
map.put(AbilityKey.LastStateBattlefield, table.getLastStateBattlefield());
map.put(AbilityKey.LastStateGraveyard, table.getLastStateGraveyard());
map.put(AbilityKey.InternalTriggerTable, table);
}
public static CardZoneTable addCardZoneTableParams(Map<AbilityKey, Object> map, forge.game.spellability.SpellAbility sa) {
CardZoneTable table = new CardZoneTable(sa.getLastStateBattlefield(), sa.getLastStateGraveyard());
addCardZoneTableParams(map, table);
return table;
}

or should we add another one that copies/gets from game?

@tool4ever tool4ever force-pushed the fixes26 branch 3 times, most recently from ac28de1 to 758f793 Compare February 27, 2024 14:03
Hanmac
Hanmac approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@Hanmac Hanmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the CardZoneTable, we need to check when we need to copy the Zones, and when its okay to get them from Game/SpellAbility

@tool4ever tool4ever marked this pull request as ready for review February 27, 2024 14:20
@tool4ever
Copy link
Contributor Author

Since this PR is getting big we could merge these fixes now and I'll do more cleanup in a follow-up

@Hanmac Hanmac merged commit dcbe9c4 into Card-Forge:master Feb 27, 2024
2 checks passed
@tool4ever tool4ever deleted the fixes26 branch March 15, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hanmac Hanmac Hanmac approved these changes

Assignees
No one assigned
Labels
Card Patch Fixing bugged card scripts Game Mechanics Rules compliance Bringing the engine or cards closer to CR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tool4ever @Hanmac