Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding DCO check #568

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Adding DCO check #568

merged 1 commit into from
Apr 6, 2023

Conversation

erikbosch
Copy link
Collaborator

@erikbosch erikbosch commented Mar 28, 2023 •
edited
Loading

PR intended to check for sign-offs. If we think this is a good addition we can add it to vss-tools as well.

When signed we get something like:

image

Result when this commit was not signed

Run pip3 install -U dco-check
Collecting dco-check
  Downloading dco_check-0.4.0-py3-none-any.whl (18 kB)
Installing collected packages: dco-check
Successfully installed dco-check-0.4.0
Detected: GitHub CI

Checking commits: 1020b7ce6a1ec3ba31a667b1af7de06af3b49261..5f94023b70cdae05188881b767a7a56080c4010c

Missing sign-off(s):

	5f94023b70cdae05188881b767a7a56080c4010c
		no sign-off found
Error: Process completed with exit code 1.

@erikbosch erikbosch force-pushed the erikbosch/erik_dco branch 2 times, most recently from 8ff0c07 to b1c3d32 Compare March 28, 2023 08:37
@erikbosch erikbosch marked this pull request as ready for review March 28, 2023 08:38
SebastianSchildt
SebastianSchildt approved these changes Mar 28, 2023
View reviewed changes
Copy link
Collaborator

@SebastianSchildt SebastianSchildt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addtion. I did see this exists already packaged (I guess it does the same, just seems to be using some nodejs internally), https://github.com/marketplace/actions/actions-dco

Any reason doing it "manually"?

@erikbosch
Copy link
Collaborator Author

Good addtion. I did see this exists already packaged (I guess it does the same, just seems to be using some nodejs internally), https://github.com/marketplace/actions/actions-dco

Any reason doing it "manually"?

Not really, your suggest way might be more beautiful, will test it.

@erikbosch erikbosch force-pushed the erikbosch/erik_dco branch 2 times, most recently from 5de265f to 7a282de Compare March 29, 2023 10:31
@erikbosch
Adding DCO check
a89a2bf 
To make sure that commits are signed off
Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com>
@erikbosch erikbosch force-pushed the erikbosch/erik_dco branch from 7a282de to a89a2bf Compare March 29, 2023 10:33
@erikbosch erikbosch merged commit 66ea49f into COVESA:master Apr 6, 2023
@erikbosch erikbosch deleted the erikbosch/erik_dco branch April 6, 2023 12:46
jdacoello pushed a commit to jdacoello/vehicle_signal_specification that referenced this pull request May 2, 2023
@erikbosch @jdacoello
Adding DCO check (COVESA#568)
7180532 
To make sure that commits are signed off
Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebastianSchildt SebastianSchildt SebastianSchildt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikbosch @SebastianSchildt