Add Marshal Function #405
Merged
Add Marshal Function #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the Marshal function which returns the TOML representation of the Go value as bytes along with any error that may occur while marshaling.
|
Seems okay to add; can you add a basic test? Or maybe just modify one of the calls in |
Added a test for the Marshal function within TestEncodeRoundTrip.
|
Wrote a test for it under |
|
Cheers, thanks |
nrdufour
pushed a commit
to nrdufour/marmitton
that referenced
this pull request
May 24, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/BurntSushi/toml](https://github.com/BurntSushi/toml) | require | minor | `v1.3.2` -> `v1.4.0` | --- ### Release Notes <details> <summary>BurntSushi/toml (github.com/BurntSushi/toml)</summary> ### [`v1.4.0`](https://github.com/BurntSushi/toml/releases/tag/v1.4.0) [Compare Source](BurntSushi/toml@v1.3.2...v1.4.0) This version requires Go 1.18 - Add toml.Marshal() ([#​405](BurntSushi/toml#405)) - Require 2-digit hour ([#​320](BurntSushi/toml#320)) - Wrap UnmarshalTOML() and UnmarshalText() return values in ParseError for position information ([#​398](BurntSushi/toml#398)) - Fix inline tables with dotted keys inside inline arrays (e.g. `k=[{a.b=1}]`) ([#​400](BurntSushi/toml#400)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzQuMyIsInVwZGF0ZWRJblZlciI6IjM3LjM3NC4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Reviewed-on: https://git.internal/nrdufour/marmitton/pulls/31 Co-authored-by: Renovate <renovate@ptinem.casa> Co-committed-by: Renovate <renovate@ptinem.casa>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the Marshal function which returns the TOML representation of the Go value as bytes along with any error that may occur while marshaling. This adds parity with the existing Unmarshal function and conforms to the standard libraries JSON package, which also has both Unmarshal and Marshal.