Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use new toml-test, fix a few bugs #293

Merged
merged 1 commit into from
Jun 14, 2021
Merged

Update to use new toml-test, fix a few bugs #293

merged 1 commit into from
Jun 14, 2021

Conversation

arp242
Copy link
Collaborator

@arp242 arp242 commented Jun 14, 2021

Update to use the new toml-test from
toml-lang/toml-test#69

Turns out quite a few failures were just because those tests were
broken. Do'h.

And fix a few minor issues:

  • nan and inf got encoded as "NaN" and "Inf".
  • Detect invalid UTF-8 and error out.
  • Don't allow keys as triple-quoted strings: """ key """ = "foo"
  • Allow encoding blank keys ("" = 1) and escapes in keys ("\n" = 1).
  • Expand string quoting with \b and \f, and other control characters as
    \u...
  • Allow multiline strings to end with the quote character: """v""""

The toml-test tests will fail because of a catch-22: the toml-test needs
this version of the toml library to work for the fix in the lexer for
the multiline strings.

Update to use the new toml-test from
toml-lang/toml-test#69

Turns out quite a few failures were just because those tests were
broken. Do'h.

And fix a few minor issues:

- nan and inf got encoded as "NaN" and "Inf".
- Detect invalid UTF-8 and error out.
- Don't allow keys as triple-quoted strings: """ key """ = "foo"
- Allow encoding blank keys ("" = 1) and escapes in keys ("\n" = 1).
- Expand string quoting with \b and \f, and other control characters as
  \u...
- Allow multiline strings to end with the quote character: """v""""

The toml-test tests will fail because of a catch-22: the toml-test needs
this version of the toml library to work for the fix in the lexer for
the multiline strings.
@arp242 arp242 merged commit cd9deba into master Jun 14, 2021
@arp242 arp242 deleted the pass-tests branch June 14, 2021 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant