Dependency conflicts fix #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BuffaloWill
approved these changes
Mar 26, 2021
There was a problem hiding this comment.
Looks great @nytr0gen. I am going to merge and then re-archive the project.
I really appreciate the great effort and contribution back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I really appreciate your work on this project.
I did notice the project wasn't working anymore because of some dependency conflicts. So I took it upon myself to to fix the dependencies by adding a
Gemfile.lockand downgrading to ruby 2.3.8I also made docker the main way of launching the project because it handles everything about the installation by itself, so it only requires one command and to have Docker installed. This was tested on Linux and Mac, but should work on the Windows version of Docker as well.
This should make it work practically forever without any new upgrade.
I made some updates to the project itself too:
Let me know if you agree with everything :D Suggestions are welcome