updated ua-parser package to 0.7.19 version #1677
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shakyShane, Why you closed PR? |
This was referenced Jun 5, 2019
|
@shakyShane please reopen and merge this PR. Your PR that closed this issue did not incorporate the fix and the targeted package version has a known security risk |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
There is a vulnerability in ua-parser package, because its version is old.
https://app.snyk.io/vuln/npm:ua-parser-js:20180227
What is the new behavior?
I updated the version of the ua-parser package. Vulnerability should not be.
Does this PR introduce a breaking change?
I'm not sure.
Reviewers
@shakyShane @shinnn