Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the madry benchmark scripts #69

Merged
merged 2 commits into from
Mar 4, 2020
Merged

fix the madry benchmark scripts #69

merged 2 commits into from
Mar 4, 2020

Conversation

zzzace2000
Copy link
Contributor

I tested out this morning and fixed things to make it work.

@gwding
Copy link
Collaborator

gwding commented Mar 4, 2020

@zzzace2000 Thanks for spotting the issue.
This bug should have appeared after #45 , where the backward in BPDAWrapper changed its input signature.

I made some rearrangements to make the backward functions in madry_et_al_utils.py to have the same input variable order with the backward in BPDAWrapper.

Merging.

@gwding gwding merged commit f42fca4 into BorealisAI:master Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zzzace2000 @gwding