Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2922 #2998

Merged
merged 3 commits into from
Jun 3, 2019
Merged

Fix #2922 #2998

merged 3 commits into from
Jun 3, 2019

Conversation

amedora
Copy link
Contributor

@amedora amedora commented May 9, 2019

Description

Accoding to the KaTeX/KaTeX's changelog and related issues, they have fixed this problem in v0.10.0, but
I've updated it to latest v0.10.1.
katex2

Issue fixed

#2922

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • ⚪ All existing tests have been passed
  • 🔘 I have attached a screenshot/video to visualize my change if possible

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label May 10, 2019
@ZeroX-DG ZeroX-DG requested a review from Rokt33r May 10, 2019 23:19
@ZeroX-DG
Copy link
Member

I'm not familiar with KaText so I'll need review from @Rokt33r . This PR is somewhat duplicated with #2576.

@Rokt33r
Copy link
Member

Rokt33r commented May 29, 2019

I think I should merge #2576. If the author of the pr doesn't response in 3 days, let's try to merge this.

@Rokt33r Rokt33r mentioned this pull request Jun 3, 2019
Closed
@Rokt33r Rokt33r merged commit f62eba9 into BoostIO:master Jun 3, 2019
@Rokt33r Rokt33r removed the awaiting review ❇️ Pull request is awaiting a review. label Jun 3, 2019
@Rokt33r Rokt33r added this to the v0.12.0 milestone Jun 3, 2019
@Flexo013 Flexo013 mentioned this pull request Jun 3, 2019
Closed
@amedora amedora deleted the katex-2922 branch June 6, 2019 05:43
@amedora amedora mentioned this pull request Jul 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rokt33r Rokt33r Awaiting requested review from Rokt33r

Assignees

@Rokt33r Rokt33r

Labels
None yet
Projects
None yet
Milestone
v0.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@amedora @ZeroX-DG @Rokt33r