Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Solarized Dark theme #1293

Merged
merged 3 commits into from
Dec 15, 2017
Merged

Add Solarized Dark theme #1293

merged 3 commits into from
Dec 15, 2017

Conversation

ytk141
Copy link
Contributor

@ytk141 ytk141 commented Dec 14, 2017

Add Solarized Dark theme
2017-12-14 15 47 26

@kazup01 Check it plz

@BoostnoteBot
Copy link
Collaborator

Please make sure to be pasted screenshots of all your changes.

@ytk141
Copy link
Contributor Author

ytk141 commented Dec 14, 2017

solarized dark theme color pallete

@kazup01
Copy link
Member

kazup01 commented Dec 14, 2017 •
edited
Loading

@ytk141 Cool 😂 I will check it soon!

cool

@kazup01 kazup01 self-requested a review December 14, 2017 07:29
@kazup01 kazup01 added the awaiting review ❇️ Pull request is awaiting a review. label Dec 14, 2017
@kazup01
Copy link
Member

kazup01 commented Dec 14, 2017

Thanks for your contribution @ytk141 !
Please check the following.

  • Could you add background color when a note is selected at note list?

dec-14-0029 16-42-24

  • Please add background color to "Finder" window. (You can open it using cmd + alt + s)

screen shot 0029-12-14 at 4 41 46 pm

Thanks!

@kazup01 kazup01 added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels Dec 14, 2017
@ytk141
Copy link
Contributor Author

ytk141 commented Dec 15, 2017

@kazup01 fixed

@kazup01 kazup01 added awaiting review ❇️ Pull request is awaiting a review. and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Dec 15, 2017
kazup01
kazup01 approved these changes Dec 15, 2017
View reviewed changes
Copy link
Member

@kazup01 kazup01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazup01 kazup01 merged commit d3995b9 into BoostIO:master Dec 15, 2017
@kazup01
Copy link
Member

kazup01 commented Dec 15, 2017

Merged. Thank you for your contribution 🎉 @ytk141

@kazup01 kazup01 added next release (v0.8.19) and removed awaiting review ❇️ Pull request is awaiting a review. Next Release labels Dec 15, 2017
@kohei-takata kohei-takata mentioned this pull request Dec 23, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazup01 kazup01 kazup01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ytk141 @BoostnoteBot @kazup01