preserves the solution passed to the fixed point solver #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fixed point solver accepts an initial solution, which in turn could be a solution for the previous attempt. Originally, it was assumed that the solution is applied to the same graph and that a solutions could be only refined on the same graph. Therefore, if applied to a different graph all solution entries that didn't have a corresponding entry in the new graph were removed from the solution. It turns out that it is quite useful to apply the same solution to different graphs even (and especially) when they are not intersecting. This PR proposes to keep all entries in the solution passed to the fixed point computation. It will update those fields that were changed, leaving those that weren't intact, basically guarantees that the newly computed solution contains the superset of the old solution.
gitoleg
approved these changes
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fixed point solver accepts an initial solution, which in turn
could be a solution for the previous attempt. Originally, it was
assumed that the solution is applied to the same graph and that
a solutions could be only refined on the same graph. Therefore, if
applied to a different graph all solution entries that didn't have
a corresponding entry in the new graph were removed from the solution.
It turns out that it is quite useful to apply the same solution to
different graphs even (and especially) when they are not
intersecting.
This PR proposes to keep all entries in the solution passed to the
fixed point computation. It will update those fields that were
changed, leaving those that weren't intact, basically guarantees that
the newly computed solution contains the superset of the old solution.