enables bap-elf #866
Merged
enables bap-elf #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in order to use `bitstring.ppx`, we should not use `ppx_driver` and `ppx_custom` predicates according to bistring META file. And ppx_jane can't be used too. That's why we just omit `bap_elf` diretory in our tags file.
ivg
approved these changes
Sep 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in order to use
bitstring.ppx, we should not useppx_driverandppx_custompredicates according to bitstring META file. And ppx_jane can't be used too. That's why we just omitbap_elfdirectory in our tags file.It turned out that we can't build
bap-elfon every compilator we support. The constraint is>= 4.04.1. And we need to add it toopamfile ofbap-elflibrary